git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, GIT Mailing-list <git@vger.kernel.org>
Subject: [PATCH 0/2] Fix -Wuninitialized warnings on older gcc
Date: Tue, 26 Mar 2013 19:08:37 +0000	[thread overview]
Message-ID: <5151F235.4080303@ramsay1.demon.co.uk> (raw)

Hi Junio,

I had prepared 3 patches, but I noticed this afternoon that
the warning in transport.c has already been fixed in maint.
These were built on the tip of master as of saturday evening
(master @ 7b592fad).

Just FYI, as of saturday, Jeff's patches in maint/master had
removed 40 warnings from the MSVC build; 34 of the warnings
were due to commit 25043d8a all on it's lonesome! [1]. The
additional patches in pu, remove an additional 14 warnings.
This leaves only the following:

    $ grep warning msvc-pout | grep uninit
    c:\msysgit\msysgit\home\ramsay\git\fast-import.c(2916) : warning C4700:\
    uninitialized local variable 'oe' used
    c:\msysgit\msysgit\home\ramsay\git\builtin\rev-list.c(341) : warning C4700:\
    uninitialized local variable 'reaches' used
    c:\msysgit\msysgit\home\ramsay\git\builtin\rev-list.c(341) : warning C4700:\
    uninitialized local variable 'all' used
    c:\msysgit\msysgit\home\ramsay\git\merge-recursive.c(1886) : warning C4700:\
    uninitialized local variable 'mrtree' used

ATB,
Ramsay Jones

[1] In case you are puzzled by this, the warning is coming from
the linker, since the msvc build is using link-time code-gen/optimisation.


Ramsay Allan Jones (2):
  fast-import: Fix an gcc -Wuninitialized warning
  cat-file: Fix an gcc -Wuninitialized warning

 builtin/cat-file.c | 2 +-
 fast-import.c      | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

-- 
1.8.2

                 reply	other threads:[~2013-03-26 19:22 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5151F235.4080303@ramsay1.demon.co.uk \
    --to=ramsay@ramsay1.demon.co.uk \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).