* [PATCH] git help config: s/insn/instruction/
@ 2013-03-27 22:53 Matthias Krüger
2013-03-28 5:59 ` Junio C Hamano
0 siblings, 1 reply; 4+ messages in thread
From: Matthias Krüger @ 2013-03-27 22:53 UTC (permalink / raw)
To: git; +Cc: matthias.krueger, kumbayo84
"insn" appears to be an in-code abbreviation and should not appear in manual/help pages.
---
Documentation/config.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/config.txt b/Documentation/config.txt
index c1f435f..f79184c 100644
--- a/Documentation/config.txt
+++ b/Documentation/config.txt
@@ -555,7 +555,7 @@ core.commentchar::
(default '#').
sequence.editor::
- Text editor used by `git rebase -i` for editing the rebase insn file.
+ Text editor used by `git rebase -i` for editing the rebase instruction file.
The value is meant to be interpreted by the shell when it is used.
It can be overridden by the `GIT_SEQUENCE_EDITOR` environment variable.
When not configured the default commit message editor is used instead.
--
1.8.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] git help config: s/insn/instruction/
2013-03-27 22:53 [PATCH] git help config: s/insn/instruction/ Matthias Krüger
@ 2013-03-28 5:59 ` Junio C Hamano
2013-03-28 8:27 ` Matthias Krüger
0 siblings, 1 reply; 4+ messages in thread
From: Junio C Hamano @ 2013-03-28 5:59 UTC (permalink / raw)
To: Matthias Krüger; +Cc: git, kumbayo84
Matthias Krüger <matthias.krueger@famsik.de> writes:
> "insn" appears to be an in-code abbreviation and should not appear in manual/help pages.
> ---
Thanks; sign-off?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] git help config: s/insn/instruction/
2013-03-28 5:59 ` Junio C Hamano
@ 2013-03-28 8:27 ` Matthias Krüger
2013-03-28 15:55 ` Junio C Hamano
0 siblings, 1 reply; 4+ messages in thread
From: Matthias Krüger @ 2013-03-28 8:27 UTC (permalink / raw)
To: git; +Cc: kumbayo84
On 03/28/2013 06:59 AM, Junio C Hamano wrote:
> Matthias Krüger <matthias.krueger@famsik.de> writes:
>
>> "insn" appears to be an in-code abbreviation and should not appear in manual/help pages.
>> ---
> Thanks; sign-off?
Oops, sorry.
Signed-off-by: Matthias Krüger <matthias.krueger@famsik.de>
(Is this sufficient or do I have to re-send the patch with the sign-off
line?)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] git help config: s/insn/instruction/
2013-03-28 8:27 ` Matthias Krüger
@ 2013-03-28 15:55 ` Junio C Hamano
0 siblings, 0 replies; 4+ messages in thread
From: Junio C Hamano @ 2013-03-28 15:55 UTC (permalink / raw)
To: Matthias Krüger; +Cc: git, kumbayo84
Matthias Krüger <matthias.krueger@famsik.de> writes:
> On 03/28/2013 06:59 AM, Junio C Hamano wrote:
>> Matthias Krüger <matthias.krueger@famsik.de> writes:
>>
>>> "insn" appears to be an in-code abbreviation and should not appear in manual/help pages.
>>> ---
>> Thanks; sign-off?
> Oops, sorry.
>
> Signed-off-by: Matthias Krüger <matthias.krueger@famsik.de>
>
> (Is this sufficient or do I have to re-send the patch with the
> sign-off line?)
I can squash it in, so there is no need to resend. The more
important thing is I won't have to for your future patches.
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-03-28 15:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-27 22:53 [PATCH] git help config: s/insn/instruction/ Matthias Krüger
2013-03-28 5:59 ` Junio C Hamano
2013-03-28 8:27 ` Matthias Krüger
2013-03-28 15:55 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).