git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Lehmann <Jens.Lehmann@web.de>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	Jonathan Nieder <jrnieder@gmail.com>,
	Git List <git@vger.kernel.org>, Jeff King <peff@peff.net>
Subject: Re: Composing git repositories
Date: Thu, 28 Mar 2013 21:25:09 +0100	[thread overview]
Message-ID: <5154A725.7030609@web.de> (raw)
In-Reply-To: <CALkWK0=GcxBh9o+sF1Q8t6SC0JU=NmPyRg6tqaOKmkJ6qDvRCA@mail.gmail.com>

Am 28.03.2013 12:48, schrieb Ramkumar Ramachandra:
> Okay, here's a first draft of the new design.  The new mediator object
> should look like:
> 
>     name = git
>     ref = v1.7.8
> 
> The name is looked up in refs/modules/<branch>, which in turn looks like:
> 
>     [submodule "git"]
>         origin = gh:artagnon/git
>         path = git
>     [submodule "magit"]
>         origin = gh:magit/magit
>         path = git/extensions/magit

What happens when you rename "magit" to "foo" in that branch and want
to check out an older commit of the same branch? That is one of the
reasons why that belongs in to a checked in .gitmodules and not
someplace untracked.

> This solves the two problems that I brought up earlier:
> - Floating submodules (which are _necessary_ if you don't want to
> propagate commits upwards to the root).

If you don't want that either don't use submodules or set the ignore
config so you won't be bothered with any changes to the submodules.
Floating up to the submodule's tip can be easily achieved with a
script (possibly checked in in the superproject). You loose the
reproducibility by doing that, but that's what you asked for. No
problem here.

> - Initializing a nested submodule without having to initialize all the
> submodules in the path leading up to it.

You cannot access a nested sub-submodule without its parent telling
you what submodules it has. Otherwise the first level submodule would
not be self-contained, so you'll need to check it out too to access
the sub-submodules. Nothing to fix here either.

> However, I suspect that we can put more information the mediator
> object to make life easier for the parent repository and make seams
> disappear.  I'm currently thinking about what information git core
> needs to behave smoothly with submodules.

To me your proposal is trying to fix non-issues and breaking stuff
that works, so I see no improvement.

  reply	other threads:[~2013-03-28 20:25 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-26  7:56 Composing git repositories Ramkumar Ramachandra
2013-03-26 16:39 ` Junio C Hamano
2013-03-27 11:49   ` Ramkumar Ramachandra
2013-03-27 16:06     ` Junio C Hamano
2013-03-27 17:02       ` Ramkumar Ramachandra
2013-03-27 17:16         ` Junio C Hamano
2013-03-27 19:26         ` Jonathan Nieder
2013-03-27 20:18           ` Junio C Hamano
2013-03-27 20:42             ` Jonathan Nieder
2013-03-28 11:48             ` Ramkumar Ramachandra
2013-03-28 20:25               ` Jens Lehmann [this message]
2013-03-28 10:01           ` Ramkumar Ramachandra
2013-03-28 18:21             ` Jonathan Nieder
2013-03-28 20:17             ` Jens Lehmann
2013-03-27 23:02         ` Jens Lehmann
2013-03-28  9:16           ` Ramkumar Ramachandra
2013-03-28 20:40             ` Jens Lehmann
2013-03-31 20:34               ` Ramkumar Ramachandra
2013-03-31 22:57                 ` Jonathan Nieder
2013-04-02 17:44                   ` Ramkumar Ramachandra
2013-04-02 17:58                     ` Jeff King
2013-04-02 19:33                       ` Ramkumar Ramachandra
2013-04-02 19:56                     ` Jens Lehmann
2013-04-02 18:03                   ` Junio C Hamano
2013-04-04  6:40                     ` Junio C Hamano
2013-04-05  2:36                       ` Duy Nguyen
2013-04-05  4:53                         ` Junio C Hamano
2013-04-05  5:27                           ` Duy Nguyen
2013-04-05  7:15                             ` Jens Lehmann
2013-03-31 23:50                 ` Phil Hord
2013-04-01 12:14                   ` Jens Lehmann
2013-04-01 14:49                     ` Phil Hord
2013-04-02 18:35                     ` Ramkumar Ramachandra
2013-04-02 18:54                       ` Jonathan Nieder
2013-04-02 19:09                         ` Junio C Hamano
2013-04-02 19:11                         ` Ramkumar Ramachandra
2013-04-02 19:20                           ` Jonathan Nieder
2013-04-02 19:29                             ` Ramkumar Ramachandra
2013-04-02 19:49                               ` Ramkumar Ramachandra
2013-04-02 19:59                       ` Jens Lehmann
2013-04-01  9:50                 ` Jens Lehmann
2013-04-01  0:16 ` Seth Robertson
2013-04-02 19:19   ` Ramkumar Ramachandra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5154A725.7030609@web.de \
    --to=jens.lehmann@web.de \
    --cc=artagnon@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).