From: Michael Haggerty <mhagger@alum.mit.edu>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, Junio C Hamano <junio@pobox.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: Bug in "git rev-parse --verify"
Date: Sat, 30 Mar 2013 06:29:40 +0100 [thread overview]
Message-ID: <51567844.7030503@alum.mit.edu> (raw)
In-Reply-To: <7vk3opr0ke.fsf@alter.siamese.dyndns.org>
On 03/30/2013 05:09 AM, Junio C Hamano wrote:
> So why not verify arguments while making sure of their type early
> with 'rev-parse --verify "$userinput^{desiredtype}"?
Yes, that's a better solution in almost all cases. Thanks for the tip.
(It doesn't change my opinion that the documentation for "rev-parse
--verify" is misleading, but given that you don't appear to want to
change its behavior I will submit a documentation patch.)
Michael
--
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/
next prev parent reply other threads:[~2013-03-30 5:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-28 13:04 Bug in "git rev-parse --verify" Michael Haggerty
2013-03-28 14:05 ` Jeff King
2013-03-28 14:55 ` Junio C Hamano
[not found] ` <CAPc5daUqzz=9TBmj2Q0MHqEc6gMHxXoGr9+JV3hq76zDKJAyCw@mail.gmail.com>
2013-03-28 15:34 ` Michael Haggerty
2013-03-28 15:38 ` Jeff King
2013-03-28 15:52 ` Michael Haggerty
2013-03-28 16:38 ` Jeff King
2013-03-28 16:52 ` Junio C Hamano
2013-03-30 3:44 ` Michael Haggerty
2013-03-30 4:09 ` Junio C Hamano
2013-03-30 4:15 ` Junio C Hamano
2013-03-30 5:29 ` Michael Haggerty [this message]
2013-03-30 6:38 ` Junio C Hamano
2013-03-30 7:05 ` Junio C Hamano
2013-03-30 8:09 ` Michael Haggerty
2013-03-30 8:14 ` Elia Pinto
2013-03-31 22:38 ` [PATCH 1/2] peel_onion: disambiguate to favor tree-ish when we want a tree-ish Junio C Hamano
2013-03-31 22:38 ` [PATCH 2/2] peel_onion(): teach $foo^{object} peeler Junio C Hamano
2013-04-02 8:20 ` Michael Haggerty
2013-04-02 15:45 ` Junio C Hamano
2013-04-02 16:32 ` Michael Haggerty
2013-04-02 16:56 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51567844.7030503@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=junio@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).