From: Jens Lehmann <Jens.Lehmann@web.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Phil Hord <phil.hord@gmail.com>, Heiko Voigt <hvoigt@hvoigt.net>,
"W. Trevor King" <wking@tremily.us>,
Peter Collingbourne <peter@pcc.me.uk>
Subject: Re: [PATCH/RFC 2/3] Teach mv to move submodules using a gitfile
Date: Wed, 10 Apr 2013 18:59:54 +0200 [thread overview]
Message-ID: <51659A8A.80605@web.de> (raw)
In-Reply-To: <7vwqsbnvxz.fsf@alter.siamese.dyndns.org>
Am 10.04.2013 01:08, schrieb Junio C Hamano:
> Jens Lehmann <Jens.Lehmann@web.de> writes:
>
>> diff --git a/submodule.c b/submodule.c
>> index 975bc87..eba9b42 100644
>> --- a/submodule.c
>> +++ b/submodule.c
>> @@ -1001,3 +1001,67 @@ int merge_submodule(unsigned char result[20], const char *path,
>> ...
>> + if (!fp)
>> + die(_("Could not create git link %s"), gitfile_name.buf);
>> + fprintf(fp, gitfile_content.buf);
>
> Perhaps.
>
> fprintf(fp, "%s", gitfile_content.buf);
Sure. Will fix in v2.
next prev parent reply other threads:[~2013-04-10 17:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 19:54 [PATCH/RFC 0/3] Teach mv to move submodules Jens Lehmann
2013-04-03 19:56 ` [PATCH/RFC 1/3] Teach mv to move submodules together with their work trees Jens Lehmann
2013-04-11 9:12 ` Ramkumar Ramachandra
2013-04-11 16:27 ` Junio C Hamano
2013-04-11 16:46 ` Junio C Hamano
2013-04-03 19:56 ` [PATCH/RFC 2/3] Teach mv to move submodules using a gitfile Jens Lehmann
2013-04-09 23:08 ` Junio C Hamano
2013-04-10 16:59 ` Jens Lehmann [this message]
2013-04-10 21:06 ` [PATCH v2 " Jens Lehmann
2013-04-11 8:37 ` Ramkumar Ramachandra
2013-04-11 18:43 ` Junio C Hamano
2013-04-03 19:57 ` [PATCH/RFC 3/3] Teach mv to update the path entry in .gitmodules for moved submodules Jens Lehmann
2013-04-11 10:06 ` Ramkumar Ramachandra
2013-04-11 16:59 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51659A8A.80605@web.de \
--to=jens.lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hvoigt@hvoigt.net \
--cc=peter@pcc.me.uk \
--cc=phil.hord@gmail.com \
--cc=wking@tremily.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).