From: Barbu Paul - Gheorghe <barbu.paul.gheorghe@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-imap-send.txt: remove the use of sslverify=false in GMail example
Date: Thu, 11 Apr 2013 16:36:01 +0300 [thread overview]
Message-ID: <5166BC41.5020202@gmail.com> (raw)
In-Reply-To: <7vmwt6mdjg.fsf@alter.siamese.dyndns.org>
On 04/10/2013 09:44 PM, Junio C Hamano wrote:
> Thanks.
My pleasure.
> While removing that item from the configuration is a good thing to
> do in the post 1.8.2.1 era, the reason why it is does not have much
> to do with "GMail is SSL capable".
Should I change the commit message in order to avoid confusion among devs that
read it?
> The configuration item is not about "Do we connect over SSL when
> talking to this host?", but is about "When we use SSL with this
> host, do we verify the certificate it gave us?".
If I change it, how should it sound?
It could be:
Since GMail's certificates can be sslverify-ed there is no need to set sslverify
to false, the example using it may confuse readers that it's needed since it's
also used in the previous example configurations, too.
Have a nice day!
--
Barbu Paul - Gheorghe
Common sense is not so common - Voltaire
Visit My GitHub profile to see my open-source projects - https://github.com/paullik
next prev parent reply other threads:[~2013-04-11 13:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-10 14:59 [PATCH] git-imap-send.txt: remove the use of sslverify=false in GMail example Barbu Paul - Gheorghe
2013-04-10 18:44 ` Junio C Hamano
2013-04-11 13:36 ` Barbu Paul - Gheorghe [this message]
2013-04-11 15:26 ` Simon Ruderich
2013-04-11 15:55 ` Barbu Paul - Gheorghe
2013-04-20 14:08 ` Simon Ruderich
2013-04-22 19:26 ` [PATCH] git-imap-send.txt: remove the use of sslverify=false Barbu Paul - Gheorghe
2013-04-24 17:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5166BC41.5020202@gmail.com \
--to=barbu.paul.gheorghe@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).