From: Michael Haggerty <mhagger@alum.mit.edu>
To: Junio C Hamano <junio@pobox.com>
Cc: Thomas Rast <trast@inf.ethz.ch>, Miklos Vajna <vmiklos@suse.cz>,
Ramkumar Ramachandra <artagnon@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH v3] cherry-pick: make sure all input objects are commits
Date: Tue, 16 Apr 2013 16:22:37 +0200 [thread overview]
Message-ID: <516D5EAD.4070503@alum.mit.edu> (raw)
In-Reply-To: <7v61znsj49.fsf@alter.siamese.dyndns.org>
On 04/15/2013 09:12 PM, Junio C Hamano wrote:
> The paths given to handle_refs() may also have to be copied before
> saved, depending on how ref iteration is implemented, details of
> which may change as Michael seems to be updating the area again.
> I think we let the callback peek ref_entry->name[] which is stable,
> so I suspect we are OK.
ref_entry->name is stable as long as invalidate_ref_cache() is not
called, and I am not even thinking of changing that (partly because I
don't have the energy to audit and adjust all of the callers).
Michael
--
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/
next prev parent reply other threads:[~2013-04-16 14:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 9:27 [PATCH] cherry-pick: better error message when the parameter is a non-commit Miklos Vajna
2013-04-08 12:27 ` Miklos Vajna
2013-04-08 16:45 ` Junio C Hamano
2013-04-08 16:56 ` Junio C Hamano
2013-04-11 9:26 ` [PATCH v2] cherry-pick: make sure all input objects are commits Miklos Vajna
2013-04-11 10:22 ` Ramkumar Ramachandra
2013-04-11 11:03 ` Miklos Vajna
2013-04-11 11:42 ` Ramkumar Ramachandra
2013-04-11 13:06 ` [PATCH v3] " Miklos Vajna
2013-04-11 13:27 ` Ramkumar Ramachandra
2013-04-15 8:44 ` Thomas Rast
2013-04-15 18:29 ` Junio C Hamano
2013-04-15 19:12 ` Junio C Hamano
2013-04-16 14:22 ` Michael Haggerty [this message]
2013-05-09 19:47 ` Junio C Hamano
2013-05-09 20:27 ` Junio C Hamano
2013-05-10 7:07 ` Miklos Vajna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516D5EAD.4070503@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=junio@pobox.com \
--cc=trast@inf.ethz.ch \
--cc=vmiklos@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).