From: Marc Branchaud <marcnarc@xiplink.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Junio C Hamano <junio@pobox.com>, Git List <git@vger.kernel.org>,
Duy Nguyen <pclouds@gmail.com>, Jeff King <peff@peff.net>
Subject: Re: [RFC/PATCH] clone: introduce clone.submoduleGitDir to relocate $GITDIR
Date: Tue, 16 Apr 2013 11:46:09 -0400 [thread overview]
Message-ID: <516D7241.8050901@xiplink.com> (raw)
In-Reply-To: <CALkWK0=2+RY0cRSJD4pbHxPuqffDEqiwc7m0+Fzk7d8=wLvULQ@mail.gmail.com>
On 13-04-16 04:21 AM, Ramkumar Ramachandra wrote:
> Junio C Hamano wrote:
>> It does not relieve "git add" (or "git submodulea add") from the
>> responsibility of moving .git directory. It only reduces the need
>> to do so.
>>
>> When the user says "add" and the repository has .git directory in
>> it, "add" (or "submodule add") is still responsible for relocating
>> it.
>
> Since you're so stubborn about it, I suppose 'git add' could call a
> function in my "new first-class program to attach detach
> worktrees/workdirs and relocate GITDIRs" as a last resort (if the user
> somehow managed to put a GITDIR in the submodule worktree despite our
> well-designed tools). But last resort is not what we should be
> discussing now: we're discussing what the design should ideally be.
> And ideally, I think we both agree that it's best if init/clone did
> the relocation.
If that's the question, then put me on the "disagree" side. I just don't see
why that approach is "best", especially if the intention is "to make 'git
add' DTRT wrt submodules, and deprecate 'git submodule add'".
M.
next prev parent reply other threads:[~2013-04-16 15:46 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-13 19:23 [RFC/PATCH] clone: introduce clone.submoduleGitDir to relocate $GITDIR Ramkumar Ramachandra
2013-04-15 1:28 ` Junio C Hamano
2013-04-15 2:48 ` Junio C Hamano
2013-04-15 8:08 ` Ramkumar Ramachandra
2013-04-15 10:14 ` Junio C Hamano
2013-04-15 11:35 ` Ramkumar Ramachandra
2013-04-15 7:59 ` Ramkumar Ramachandra
2013-04-15 8:19 ` Ramkumar Ramachandra
2013-04-15 9:25 ` Duy Nguyen
2013-04-15 9:47 ` Ramkumar Ramachandra
2013-04-15 9:45 ` Junio C Hamano
2013-04-15 11:48 ` Ramkumar Ramachandra
2013-04-15 15:50 ` Marc Branchaud
2013-04-15 17:50 ` Junio C Hamano
2013-04-15 18:00 ` Ramkumar Ramachandra
2013-04-15 18:43 ` Jeff King
2013-04-15 20:52 ` Junio C Hamano
2013-04-16 8:13 ` Ramkumar Ramachandra
2013-04-16 15:39 ` Marc Branchaud
2013-04-15 18:50 ` Marc Branchaud
2013-04-16 8:17 ` Ramkumar Ramachandra
2013-04-16 15:46 ` Marc Branchaud
2013-04-15 18:43 ` Marc Branchaud
2013-04-15 18:50 ` Junio C Hamano
2013-04-15 20:32 ` Marc Branchaud
2013-04-15 20:56 ` Junio C Hamano
2013-04-16 8:21 ` Ramkumar Ramachandra
2013-04-16 15:46 ` Marc Branchaud [this message]
2013-04-15 17:50 ` Ramkumar Ramachandra
2013-04-16 2:58 ` Jonathan Nieder
2013-04-16 8:36 ` Ramkumar Ramachandra
2013-04-16 17:28 ` Junio C Hamano
2013-04-17 15:48 ` Jonathan Nieder
2013-04-17 10:22 ` Duy Nguyen
2013-04-17 10:53 ` Ramkumar Ramachandra
2013-04-17 10:59 ` Duy Nguyen
2013-04-17 11:13 ` Ramkumar Ramachandra
2013-04-17 11:36 ` Duy Nguyen
2013-04-17 15:02 ` Ramkumar Ramachandra
2013-04-17 23:01 ` Duy Nguyen
2013-04-17 17:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516D7241.8050901@xiplink.com \
--to=marcnarc@xiplink.com \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=junio@pobox.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).