git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Manlio Perillo <manlio.perillo@gmail.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
	"Matthieu Moy" <Matthieu.Moy@imag.fr>,
	"SZEDER Gábor" <szeder@ira.uka.de>
Subject: Re: [PATCH 00/11] completion: general cleanups
Date: Sat, 27 Apr 2013 13:33:44 +0200	[thread overview]
Message-ID: <517BB798.4070703@gmail.com> (raw)
In-Reply-To: <1367057994-19887-1-git-send-email-felipe.contreras@gmail.com>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Il 27/04/2013 12:19, Felipe Contreras ha scritto:
> Hi,
> 
> Basically while trying to understand the code for path completion, I found that
> a lot of code was duplicated, and for not much gain.
> 
> I also noticed that doing 'git add file' doesn't add the trailing space as
> before. It's not clear if it should be possible to do that with -o filenames,
> but after all, what do -o filenames gives us? Nothing we can't do ourselves,
> apparently.
> 

No, you can not do it yourself, as far as I know.

I added the `compopt -o filenames` on Junio request for something like
"It  would be nice if completion for real files would behave like
builtin bash completion", if I remember correctly.

Try `git rm contrib/completion/<TAB>`, in the git reporitory.

Using the new feature, bash will suggest:
"git-completion.bash  git-completion.tcsh  git-completion.zsh
git-prompt.sh"

Old behaviour, instead, was to suggest:
"contrib/completion/git-completion.bash
contrib/completion/git-completion.zsh
contrib/completion/git-completion.tcsh  contrib/completion/git-prompt.sh"

I tried several things, but I was unable to emulate Bash builtin file
completion, whithout having to use `compopt -o filenames`.



As far as the "double slash" problem with the
__git_index_file_list_filter_bash function, please try
`git rm contrib<TAB>`.

With current code, Bash will suggest:
"blameview/ diffall/ git-shell-commands/"

If you remove the __git_index_file_list_filter_bash function and use
__git_index_file_list_filter_compat instead, Bash will suggest:

"blameview// diffall// git-shell-commands//"

I can confirm this on my system, and it was confirmed by another user.
It only happens when you use `compopt -o filenames`. I don't know if
this is a bug or a feature, but I can try to ask to Bash mailing list,
so that we can update the comment to make more clear why a separate
function was needed.


> [...]


Regards  Manlio
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAlF7t5gACgkQscQJ24LbaUSO5QCffllxM8RbGUP47kb7uL5J3drF
hkUAn26ezKptTAC412EJZnxjh7RVcdAO
=Piyz
-----END PGP SIGNATURE-----

  parent reply	other threads:[~2013-04-27 11:34 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-27 10:19 [PATCH 00/11] completion: general cleanups Felipe Contreras
2013-04-27 10:19 ` [PATCH 01/11] completion: add file completion tests Felipe Contreras
2013-04-27 10:19 ` [PATCH 02/11] completion: document tilde expansion failure in tests Felipe Contreras
2013-04-27 10:19 ` [PATCH 03/11] completion; remove unuseful comments Felipe Contreras
2013-04-27 10:19 ` [PATCH 04/11] completion: use __gitcompadd for __gitcomp_file Felipe Contreras
2013-04-27 10:19 ` [PATCH 05/11] completion: refactor diff_index wrappers Felipe Contreras
2013-04-27 10:19 ` [PATCH 06/11] completion: refactor __git_complete_index_file() Felipe Contreras
2013-04-27 10:19 ` [PATCH 07/11] completion: avoid compopt -o filenames Felipe Contreras
2013-04-27 10:19 ` [PATCH 08/11] completion: get rid of __gitcomp_file() Felipe Contreras
2013-04-27 10:19 ` [PATCH 09/11] completion: add space after completed filename Felipe Contreras
2013-04-27 10:19 ` [PATCH 10/11] completion: remove __git_index_file_list_filter() Felipe Contreras
2013-04-27 10:19 ` [PATCH 11/11] completion: zsh: add proper file support Felipe Contreras
2013-04-27 11:33 ` Manlio Perillo [this message]
2013-04-27 12:36   ` [PATCH 00/11] completion: general cleanups Felipe Contreras
2013-04-27 13:07     ` Felipe Contreras
2013-04-27 15:40       ` Manlio Perillo
2013-04-27 19:15         ` Felipe Contreras
2013-04-27 19:43           ` Felipe Contreras
2013-04-27 20:13           ` Manlio Perillo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=517BB798.4070703@gmail.com \
    --to=manlio.perillo@gmail.com \
    --cc=Matthieu.Moy@imag.fr \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=szeder@ira.uka.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).