git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Haggerty <mhagger@alum.mit.edu>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Felipe Contreras <felipe.contreras@gmail.com>,
	Git Mailing List <git@vger.kernel.org>,
	Junio C Hamano <gitster@pobox.com>,
	Ramkumar Ramachandra <artagnon@gmail.com>,
	Michael J Gruber <git@drmicha.warpmail.net>,
	Jon Seymour <jon.seymour@gmail.com>
Subject: Re: [PATCH] Add new @ shortcut for HEAD
Date: Tue, 30 Apr 2013 09:09:52 +0200	[thread overview]
Message-ID: <517F6E40.1040606@alum.mit.edu> (raw)
In-Reply-To: <CACsJy8D_gPpprETkAxf+eYp5DMt7uVt6nanCwthZO=vVfBT28Q@mail.gmail.com>

On 04/30/2013 07:54 AM, Duy Nguyen wrote:
> On Tue, Apr 30, 2013 at 2:35 AM, Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
>> So we can type '@' instead of 'HEAD@', or rather 'HEAD'. So now we can
>> use 'git show @~1', and all that goody goodness.
> 
> I like this. I haven't spent a lot of time on thinking about
> ambiguation. But I think we're safe there. '@' is not overloaded much
> like ':', '^' or '~'.
> 
>> This patch allows 'HEAD@' to be the same as 'HEAD@{0}', and similarly with
>> 'master@'.
> 
> I'm a bit reluctant to this. It looks like incomplete syntax to me as
> '@' has always been followed by '{'. Can we have the lone '@' candy
> but reject master@ and HEAD@? There's no actual gain in writing
> master@ vs master@{0}.

According to git-check-ref-format(1), an "@" character is currently
legal in a reference name as long as it is not followed by "{".  As an
example, git-svn uses "@" in reference names (e.g.,
"refs/remotes/svn/tags/foo@56945"), I believe when a Subversion branch
or tag is deleted then re-created.

This is not to say that the rule can't be changed and/or that the
git-svn use of such tag names conflicts with the proposed new syntax.
But it can definitely not be excluded that the new pattern will be
ambiguous with refnames that are already in use "in the wild".

Amusingly, it is already possible to define a reference or symbolic
reference named "@".  So all that you need to do is type

    git symbolic-ref -m "Create @ alias for HEAD" @ HEAD

to get the shortcut that you want :-)

Michael

-- 
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/

  parent reply	other threads:[~2013-04-30  7:10 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-29 19:35 [PATCH] Add new @ shortcut for HEAD Felipe Contreras
2013-04-29 19:43 ` Ramkumar Ramachandra
2013-04-29 20:01 ` Junio C Hamano
2013-04-29 20:14   ` Felipe Contreras
2013-04-29 20:24     ` Junio C Hamano
2013-04-29 20:38       ` Felipe Contreras
2013-04-29 21:01         ` Junio C Hamano
2013-04-29 20:02 ` Junio C Hamano
2013-04-29 20:23   ` Felipe Contreras
2013-04-29 21:36     ` Felipe Contreras
2013-04-29 22:50       ` Junio C Hamano
2013-04-30  0:53         ` Jonathan Nieder
2013-04-30 17:54           ` Junio C Hamano
2013-04-30 18:17             ` Felipe Contreras
2013-04-29 22:38 ` Junio C Hamano
2013-04-29 22:49   ` Felipe Contreras
2013-04-29 23:06     ` Junio C Hamano
2013-04-29 23:10       ` Felipe Contreras
2013-04-30  5:54 ` Duy Nguyen
2013-04-30  6:10   ` Felipe Contreras
2013-04-30  6:17     ` Duy Nguyen
2013-04-30  6:20       ` Felipe Contreras
2013-04-30  6:30     ` Duy Nguyen
2013-04-30  7:55       ` Felipe Contreras
2013-04-30  7:09   ` Michael Haggerty [this message]
2013-04-30  7:35     ` Ramkumar Ramachandra
2013-04-30 10:16       ` Duy Nguyen
2013-04-30 11:10         ` Ramkumar Ramachandra
2013-04-30 18:54       ` Ramkumar Ramachandra
2013-04-30 10:12     ` Duy Nguyen
2013-04-30 17:22   ` Junio C Hamano
2013-04-30 17:37     ` Ramkumar Ramachandra
2013-04-30 17:40     ` Ramkumar Ramachandra
2013-04-30 17:56       ` Junio C Hamano
2013-04-30 18:04         ` Ramkumar Ramachandra
2013-04-30 18:20       ` Felipe Contreras
2013-04-30 18:45         ` Ramkumar Ramachandra
2013-04-30 22:08           ` Felipe Contreras
2013-04-30 17:47     ` Felipe Contreras
2013-04-30 17:56       ` Jeff King
2013-04-30 18:18         ` Felipe Contreras
2013-04-30 19:42     ` Junio C Hamano
2013-04-30 19:53       ` Ramkumar Ramachandra
2013-04-30 20:05         ` Junio C Hamano
2013-04-30 20:37           ` Ramkumar Ramachandra
2013-04-30 19:59       ` Junio C Hamano
2013-04-30 22:17       ` Felipe Contreras
2013-04-30 22:27         ` Junio C Hamano
2013-04-30 22:38           ` Felipe Contreras
2013-04-30 22:42             ` Junio C Hamano
2013-04-30 22:53               ` Felipe Contreras
2013-04-30 23:00                 ` Felipe Contreras
2013-04-30 23:19                   ` Felipe Contreras
2013-04-30 23:24                     ` Junio C Hamano
2013-04-30  6:07 ` Duy Nguyen
2013-04-30  6:11   ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=517F6E40.1040606@alum.mit.edu \
    --to=mhagger@alum.mit.edu \
    --cc=artagnon@gmail.com \
    --cc=felipe.contreras@gmail.com \
    --cc=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jon.seymour@gmail.com \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).