git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Lehmann <Jens.Lehmann@web.de>
To: Chris Packham <judge.packham@gmail.com>
Cc: GIT <git@vger.kernel.org>
Subject: Re: Fwd: Uninit'ed submodules
Date: Mon, 06 May 2013 21:16:33 +0200	[thread overview]
Message-ID: <51880191.2070809@web.de> (raw)
In-Reply-To: <CAFOYHZDKTYFNRHUwdas7kZKs8UbdrY=hAA0SVqbz48NjWsHKww@mail.gmail.com>

Am 06.05.2013 02:19, schrieb Chris Packham:
> This did get me thinking. Why does an uninitialized submodule need to
> have an empty directory? If it didn't the maintainer in question
> probably would have realized that he needed to run "git submodule
> update --init" when his "cd submodule" command failed.
> 
> I'm guessing there is a good reason for the empty directory - perhaps
> so that git can notice the fact that it exists in the worktree but is
> out of date?  If it does need to have some presence in the worktree
> why not as a file? That way the cd command would still fail (albeit
> with a different error) providing the necessary indication to the
> user. The submodule update --init could then change from file -> dir
> when it actually gets populated.

Hmm, to me an empty directory is the natural representation of an
unpopulated submodule, but I see why that made it hard for your
maintainer to notice the fact that the submodule was uninitialized.
I suspect changing an unpopulated submodule to be represented by a
file will surprise quite some users (some of which will probably
come up with perfectly valid use cases such a change will break).

What about the following: Today's Git completely ignores empty
submodule directories, but I think that when the recursive checkout
support is there, the "submodule.autoupdate" flag - which I believe
should control that behavior - could also make those empty submodule
directories show up in "git status" as being unpopulated (after all
they are configured to be updated automatically, so not having them
populated is something Git should show). Would something like this
have helped here?

Until then I can only propose to establish a best practice of using
"git clone --recurse-submodules" in these situations to avoid the
problem you described.

  reply	other threads:[~2013-05-06 19:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAFOYHZCfL2uqnUkb=7kSdpudKvYrfMo9saJ8eNsj5mYDQgHVuA@mail.gmail.com>
2013-05-06  0:19 ` Fwd: Uninit'ed submodules Chris Packham
2013-05-06 19:16   ` Jens Lehmann [this message]
2013-05-07  8:01     ` Chris Packham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51880191.2070809@web.de \
    --to=jens.lehmann@web.de \
    --cc=git@vger.kernel.org \
    --cc=judge.packham@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).