From: Sven Strickroth <sven@cs-ware.de>
To: git@vger.kernel.org
Cc: Ramsay Jones <ramsay@ramsay1.demon.co.uk>,
Junio C Hamano <gitster@pobox.com>,
Erik Faye-Lund <kusmabite@gmail.com>,
Jonathan Nieder <jrnieder@gmail.com>,
Johannes Sixt <j6t@kdbg.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH 1/5] msvc: Fix compilation errors caused by poll.h emulation
Date: Thu, 09 May 2013 23:12:28 +0200 [thread overview]
Message-ID: <518C113C.3080106@cs-ware.de> (raw)
In-Reply-To: <518C0890.9050508@ramsay1.demon.co.uk>
Am 09.05.2013 22:35 schrieb Ramsay Jones:
> Note that '-Icompat/poll' is passed on the command-line (it is split at -Icomp
> above), which comes from:
>
> ramsay (tmp) ms $ git grep -n 'compat/poll'
> Makefile:647:LIB_H += compat/poll/poll.h
> Makefile:1235: COMPAT_CFLAGS += -DNO_POLL -Icompat/poll
> Makefile:1236: COMPAT_OBJS += compat/poll/poll.o
> ramsay (tmp) ms $
>
> I have a patch which allows me to generate the preprocessed output file
> and, after running it on git.c (=> git.i), I can see that msvc reads the
> compat/poll/poll.h file. (from line 128 of git-compat-util.h).
>
> Are you using a MSVC "project" file? If so, is it equivalent to the Makefile?
> Has the "#include" behaviour changed between MSVC 2008 -> MSVC 2012?
Thank you for your explanation. The problem for me was, that
_WIN32_WINNT was set to 0x0600 and thus winsck2.h was also declaring pollfd.
Building libgit works now.
--
Best regards,
Sven Strickroth
PGP key id F5A9D4C4 @ any key-server
prev parent reply other threads:[~2013-05-09 21:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 18:28 [PATCH 1/5] msvc: Fix compilation errors caused by poll.h emulation Ramsay Jones
2013-05-09 1:42 ` Sven Strickroth
2013-05-09 20:35 ` Ramsay Jones
2013-05-09 21:12 ` Sven Strickroth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518C113C.3080106@cs-ware.de \
--to=sven@cs-ware.de \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=jrnieder@gmail.com \
--cc=kusmabite@gmail.com \
--cc=ramsay@ramsay1.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).