git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Torsten Bögershausen" <tboegi@web.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Torsten Bögershausen" <tboegi@web.de>,
	felipe.contreras@gmail.com, git@vger.kernel.org
Subject: Re: [PATCH] test-bzr: Do not use unportable sed "\+"
Date: Sat, 11 May 2013 22:35:08 +0200	[thread overview]
Message-ID: <518EAB7C.3010508@web.de> (raw)
In-Reply-To: <7v8v3lwa5p.fsf@alter.siamese.dyndns.org>

On 11.05.13 22:09, Junio C Hamano wrote:
> Torsten Bögershausen <tboegi@web.de> writes:
> 
>> I did,
>> the interesting thing is that the test passes with and without your patch.
>> (After enabling  GIT_TEST_LONG and GIT_TEST_HTTPD in both cases)
> 
> Strange.  Do you see differences between the produced packed-refs
> file?

The original version seems to look like this:
:1 666527db455708922859283c673094002092910b
:2 1e2acf73c6db881cfb1d56d67662e3d9260be2cf
[snip]

The "fixed POSIX version" follows that style:
666527db455708922859283c673094002092910b refs/tags/blablablablablablablablablablablablablablablablablablablablablablablablablablablablablabla-1
1e2acf73c6db881cfb1d56d67662e3d9260be2cf refs/tags/blablablablablablablablablablablablablablablablablablablablablablablablablablablablablabla-2
[snip]

(Just to verify the changes:)
diff --git a/t/t5551-http-fetch.sh b/t/t5551-http-fetch.sh
index b23efbb..68965f0 100755
--- a/t/t5551-http-fetch.sh
+++ b/t/t5551-http-fetch.sh
@@ -210,8 +210,11 @@ test_expect_success EXPENSIVE 'create 50,000 tags in the repo' '
        # now assign tags to all the dangling commits we created above
        tag=$("$PERL_PATH" -e "print \"bla\" x 30") &&
        sed -e "s/^:\(.\+\) \(.\+\)$/\2 refs\/tags\/$tag-\1/" <marks >>packed-refs
+       sed -e "s|^:\([^ ]*\) \(.*\)$|\2 refs/tags/$tag-\1|" <marks >packed-refs.junio
+       sed -e "s/^:\(.\+\) \(.\+\)$/\2 refs\/tags\/$tag-\1/" <marks >packed-refs.orig
        )
 '
+       exit 0

  reply	other threads:[~2013-05-11 20:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-11 13:25 [PATCH] test-bzr: Do not use unportable sed "\+" Torsten Bögershausen
2013-05-11 18:52 ` Junio C Hamano
2013-05-11 19:45   ` Junio C Hamano
2013-05-11 20:00     ` Torsten Bögershausen
2013-05-11 20:09       ` Junio C Hamano
2013-05-11 20:35         ` Torsten Bögershausen [this message]
2013-05-12  3:14           ` Junio C Hamano
2013-05-12 22:50             ` [PATCH] t5551: do not use unportable sed '\+' Junio C Hamano
2013-05-13 15:17               ` Torsten Bögershausen
2013-05-13 16:30                 ` Junio C Hamano
2013-05-13 18:24                   ` Torsten Bögershausen
2013-05-13 18:36                     ` Junio C Hamano
2013-05-11 20:11 ` [PATCH] test-bzr: Do not use unportable sed "\+" Torsten Bögershausen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=518EAB7C.3010508@web.de \
    --to=tboegi@web.de \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).