From: "Torsten Bögershausen" <tboegi@web.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Torsten Bögershausen" <tboegi@web.de>, git@vger.kernel.org
Subject: Re: [PATCH] t5551: do not use unportable sed '\+'
Date: Mon, 13 May 2013 20:24:44 +0200 [thread overview]
Message-ID: <51912FEC.6020909@web.de> (raw)
In-Reply-To: <7vtxm6n8pj.fsf@alter.siamese.dyndns.org>
On 2013-05-13 18.30, Junio C Hamano wrote:
> Torsten Bögershausen <tboegi@web.de> writes:
>
>> On 2013-05-13 00.50, Junio C Hamano wrote:
>>> Signed-off-by: Junio C Hamano <gitster@pobox.com>
>>> ---
>>> t/t5551-http-fetch.sh | 8 ++++++--
>>> 1 file changed, 6 insertions(+), 2 deletions(-)
>>>
>> Thanks, works like a charm, tested on Mac OS.
>> /torsten
>
> Thanks; I take it that you reverted the "sed fix" part and saw the
> updated "clone" check fail with the platform "sed"?
In my first test with the fix the test case passed.
Then the sed expression was only manipulated to verify that the TC failes.
And now I took even the original expression and have verfied it is failing.
The short version: Yes
next prev parent reply other threads:[~2013-05-13 18:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-11 13:25 [PATCH] test-bzr: Do not use unportable sed "\+" Torsten Bögershausen
2013-05-11 18:52 ` Junio C Hamano
2013-05-11 19:45 ` Junio C Hamano
2013-05-11 20:00 ` Torsten Bögershausen
2013-05-11 20:09 ` Junio C Hamano
2013-05-11 20:35 ` Torsten Bögershausen
2013-05-12 3:14 ` Junio C Hamano
2013-05-12 22:50 ` [PATCH] t5551: do not use unportable sed '\+' Junio C Hamano
2013-05-13 15:17 ` Torsten Bögershausen
2013-05-13 16:30 ` Junio C Hamano
2013-05-13 18:24 ` Torsten Bögershausen [this message]
2013-05-13 18:36 ` Junio C Hamano
2013-05-11 20:11 ` [PATCH] test-bzr: Do not use unportable sed "\+" Torsten Bögershausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51912FEC.6020909@web.de \
--to=tboegi@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).