git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Beller <stefanbeller@googlemail.com>
To: Stefano Lattarini <stefano.lattarini@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] fast-import: Remove redundant assignment of 'oe' to itself.
Date: Sun, 26 May 2013 22:23:32 +0200	[thread overview]
Message-ID: <51A26F44.4020406@googlemail.com> (raw)
In-Reply-To: <51A26DBD.80106@gmail.com>

The line in question was not fixed up, but originally added in
85c6239. However I see your point, it may reintroduce warnings.

Regards,
Stefan

On 05/26/2013 10:17 PM, Stefano Lattarini wrote:
> On 05/26/2013 10:14 PM, Stefan Beller wrote:
>> It's not done very often.
>>
> Of course; it's done only in those places where GCC gave spurious
> warnings.  And it's done for no other reason that to silence said
> warnings.
> 
>> [SNIP] rest of message
> 
> Regards,
>   Stefano
> 

  reply	other threads:[~2013-05-26 20:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-26 20:05 [PATCH] fast-import: Remove redundant assignment of 'oe' to itself Stefan Beller
2013-05-26 20:08 ` Stefano Lattarini
2013-05-26 20:14   ` Stefan Beller
2013-05-26 20:17     ` Stefano Lattarini
2013-05-26 20:23       ` Stefan Beller [this message]
2013-05-28  8:22   ` Joachim Schmitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51A26F44.4020406@googlemail.com \
    --to=stefanbeller@googlemail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=stefano.lattarini@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).