git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Sixt <j.sixt@viscovery.net>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] completion: zsh: improve bash script loading
Date: Wed, 29 May 2013 08:17:50 +0200	[thread overview]
Message-ID: <51A59D8E.1040502@viscovery.net> (raw)
In-Reply-To: <1369797840-3103-1-git-send-email-felipe.contreras@gmail.com>

Am 5/29/2013 5:24, schrieb Felipe Contreras:
> +if [ -z "$script" ]; then
> +	local -a locations
> +	locations=(
> +		'/etc/bash_completion.d/git' # fedora, old debian
> +		'/usr/share/bash-completion/completions/git' # arch, ubuntu, new debian
> +		'/usr/share/bash-completion/git' # gentoo
> +		$(dirname ${funcsourcetrace[1]%:*})/git-completion.bash
> +		)

Won't you need

	local e

here, or does it not matter?

> +	for e in $locations; do
> +		test -f $e && script="$e" && break
> +	done
> +fi

-- Hannes

  reply	other threads:[~2013-05-29  6:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-29  3:24 [PATCH] completion: zsh: improve bash script loading Felipe Contreras
2013-05-29  6:17 ` Johannes Sixt [this message]
2013-05-29  6:30   ` Felipe Contreras
2013-05-29 17:49     ` Junio C Hamano
2013-05-29 19:30       ` Felipe Contreras
2013-05-29 19:58         ` Junio C Hamano
  -- strict thread matches above, loose matches on Subject: below --
2013-05-25  3:31 Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51A59D8E.1040502@viscovery.net \
    --to=j.sixt@viscovery.net \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).