From: Karsten Blees <karsten.blees@gmail.com>
To: Pat Thoyts <patthoyts@gmail.com>
Cc: msysGit <msysgit@googlegroups.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Sebastian Schuberth <sschuberth@gmail.com>,
Git List <git@vger.kernel.org>, Adam Spiers <git@adamspiers.org>
Subject: t0008-ignores failure (was: Git for Windows 1.8.3)
Date: Thu, 30 May 2013 03:13:27 +0200 [thread overview]
Message-ID: <51A6A7B7.4010802@gmail.com> (raw)
In-Reply-To: <CABNJ2G+u96P+_=Q7it0KbK9E01qunz7XZ7e3zCZvaTaOUuTQqQ@mail.gmail.com>
Am 25.05.2013 21:16, schrieb Pat Thoyts:
> On that note -- with this merge as it now stands I get the following
> test failures:
>
> t0008-ignores.sh 155, 158, 162, 164
These tests fail because they use absolute paths, e.g. "C:/.../global-excludes", which is then translated to "C<NUL>/.../global-excludes". Can be fixed like so:
--- 8< ---
--- a/t/t0008-ignores.sh
+++ b/t/t0008-ignores.sh
@@ -5,7 +5,7 @@ test_description=check-ignore
. ./test-lib.sh
init_vars () {
- global_excludes="$(pwd)/global-excludes"
+ global_excludes="global-excludes"
}
enable_global_excludes () {
---
However, this raises the question whether colon is such a good choice as separator in 'git-check-ignore --verbose' output.
':' conflicts at least with Windows absolute paths and ADS names, and also with URLs (in case someone finds 'git ls-files --exclude-from=http://git-tricks.foo/special-exclude-file' useful enough to implement :-)
I realize colon was chosen to mimic git-check-attr, however, check-attr prints relative paths only (I think?).
How about using TAB or '|' instead? AFAICT, these are typically not used in paths or glob patterns.
Cheers,
Karsten
--
--
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.
You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en
---
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
next parent reply other threads:[~2013-05-30 1:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CABNJ2G+u96P+_=Q7it0KbK9E01qunz7XZ7e3zCZvaTaOUuTQqQ@mail.gmail.com>
2013-05-30 1:13 ` Karsten Blees [this message]
2013-05-30 2:21 ` t0008-ignores failure Junio C Hamano
2013-05-30 2:52 ` Jeff King
2013-05-30 2:55 ` Jeff King
2013-05-30 6:58 ` Johannes Sixt
2013-05-30 15:15 ` t0008-ignores failure (was: Git for Windows 1.8.3) Johannes Schindelin
2013-05-30 15:45 ` Pat Thoyts
2013-05-30 17:14 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51A6A7B7.4010802@gmail.com \
--to=karsten.blees@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@adamspiers.org \
--cc=git@vger.kernel.org \
--cc=msysgit@googlegroups.com \
--cc=patthoyts@gmail.com \
--cc=sschuberth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).