git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Haggerty <mhagger@alum.mit.edu>
To: Ramsay Jones <ramsay@ramsay1.demon.co.uk>,
	Junio C Hamano <gitster@pobox.com>
Cc: GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] object.c: Fix a sparse warning
Date: Sun, 02 Jun 2013 08:12:42 +0200	[thread overview]
Message-ID: <51AAE25A.6080009@alum.mit.edu> (raw)
In-Reply-To: <51AA3363.8030705@ramsay1.demon.co.uk>

On 06/01/2013 07:46 PM, Ramsay Jones wrote:
> 
> Sparse issues an "'object_array_slopbuf' not declared. Should it be
> static?" warning. In order to suppress the warning, since this
> symbol does not need more than file visibility, we simply add the
> static modifier to its declaration.
> 
> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> ---
> 
> Hi Michael,
> 
> If you need to re-roll the patches in your 'mh/reflife' branch,
> could you please squash this into the patch corresponding to
> commit cbdeb23e ("object_array_entry: fix memory handling of
> the name field", 25-05-2013).

Ramsay, thanks for fixing this.

Junio, it doesn't seem worth spamming the list with a re-roll for this
and the other 1-line fixup commit that I already sent.  Would you mind
either pulling the re-rolled version that I published here:

    git://github.com/mhagger/git.git
    branch reflife-v3, 50f7a18ee9ad537a7bf7992d6eb145299a4884b9

or squashing them onto the patch series yourself?  Let me know if this
is inconvenient.

Thanks,
Michael

-- 
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/

      reply	other threads:[~2013-06-02  6:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-01 17:46 [PATCH] object.c: Fix a sparse warning Ramsay Jones
2013-06-02  6:12 ` Michael Haggerty [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51AAE25A.6080009@alum.mit.edu \
    --to=mhagger@alum.mit.edu \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=ramsay@ramsay1.demon.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).