From: "Célestin Matte" <celestin.matte@ensimag.fr>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: Eric Sunshine <sunshine@sunshineco.com>,
Git List <git@vger.kernel.org>,
benoit.person@ensimag.fr
Subject: Re: [PATCH v2 14/22] git-remote-mediawiki: Check return value of open + remove import of unused open2
Date: Sat, 08 Jun 2013 20:45:04 +0200 [thread overview]
Message-ID: <51B37BB0.7000504@ensimag.fr> (raw)
In-Reply-To: <vpqd2rwv40f.fsf@anie.imag.fr>
Le 08/06/2013 20:41, Matthieu Moy a écrit :
> Célestin Matte <celestin.matte@ensimag.fr> writes:
>
>> Le 08/06/2013 02:14, Eric Sunshine a écrit :
>>> These two changes are unrelated and could be split into distinct
>>> patches (IMHO, though others may disagree).
>>
>> Two distinct patches or two distinct commits?
>
> That's the same. You write commits locally, send them as patches, and
> Junio uses "git am" to turn the patches back into commits.
>
Oh, I thought a part of a patch was called a commit. So the question was
rather: "Should it be sent to this list independently from this series
of patches?".
--
Célestin Matte
next prev parent reply other threads:[~2013-06-08 18:45 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 21:42 [PATCH v2 00/22] git-remote-mediawiki: Follow perlcritic's recommandations Célestin Matte
2013-06-07 21:42 ` [PATCH v2 01/22] git-remote-mediawiki: Replace :utf8 by :encoding(UTF-8) Célestin Matte
2013-06-07 21:42 ` [PATCH v2 02/22] git-remote-mediawiki: Use the Readonly module instead of the constant pragma Célestin Matte
2013-06-08 3:23 ` Jeff King
2013-06-08 8:51 ` Benoît Person
2013-06-08 13:01 ` Célestin Perdu
2013-06-08 17:31 ` Jeff King
2013-06-08 18:27 ` Matthieu Moy
2013-06-07 21:42 ` [PATCH v2 03/22] git-remote-mediawiki: Always end a subroutine with a return Célestin Matte
2013-06-07 21:42 ` [PATCH v2 04/22] git-remote-mediawiki: Move a variable declaration at the top of the code Célestin Matte
2013-06-07 21:42 ` [PATCH v2 05/22] git-remote-mediawiki: Change syntax of map calls Célestin Matte
2013-06-07 21:42 ` [PATCH v2 06/22] git-remote-mediawiki: Rewrite unclear line of instructions Célestin Matte
2013-06-07 21:42 ` [PATCH v2 07/22] git-remote-mediawiki: Change style of some regular expressions Célestin Matte
2013-06-08 0:12 ` Eric Sunshine
2013-06-07 21:42 ` [PATCH v2 08/22] git-remote-mediawiki: Add newline in the end of die() error messages Célestin Matte
2013-06-07 21:42 ` [PATCH v2 09/22] git-remote-mediawiki: Change the name of a variable Célestin Matte
2013-06-07 21:42 ` [PATCH v2 10/22] git-remote-mediawiki: Turn double-negated expressions into simple expressions Célestin Matte
2013-06-07 21:42 ` [PATCH v2 11/22] git-remote-mediawiki: Remove unused variable $entry Célestin Matte
2013-06-07 21:42 ` [PATCH v2 12/22] git-remote-mediawiki: Rename a variable ($last) which has the name of a keyword Célestin Matte
2013-06-07 21:42 ` [PATCH v2 13/22] git-remote-mediawiki: Assign a variable as undef and make proper indentation Célestin Matte
2013-06-07 21:42 ` [PATCH v2 14/22] git-remote-mediawiki: Check return value of open + remove import of unused open2 Célestin Matte
2013-06-08 0:14 ` Eric Sunshine
2013-06-08 15:54 ` Célestin Matte
2013-06-08 18:41 ` Matthieu Moy
2013-06-08 18:45 ` Célestin Matte [this message]
2013-06-08 19:04 ` Matthieu Moy
2013-06-09 4:52 ` Eric Sunshine
2013-06-07 21:42 ` [PATCH v2 15/22] git-remote-mediawiki: Put long code into a subroutine Célestin Matte
2013-06-08 0:27 ` Eric Sunshine
2013-06-07 21:42 ` [PATCH v2 16/22] git-remote-mediawiki: Modify strings for a better coding-style Célestin Matte
2013-06-08 0:39 ` Eric Sunshine
2013-06-08 20:32 ` Célestin Matte
2013-06-09 4:44 ` Eric Sunshine
2013-06-07 21:42 ` [PATCH v2 17/22] git-remote-mediawiki: Brace file handles for print for more clarity Célestin Matte
2013-06-08 0:42 ` Eric Sunshine
2013-06-07 21:42 ` [PATCH v2 18/22] git-remote-mediawiki: Replace "unless" statements with negated "if" statements Célestin Matte
2013-06-07 21:42 ` [PATCH v2 19/22] git-remote-mediawiki: Don't use quotes for empty strings Célestin Matte
2013-06-07 21:42 ` [PATCH v2 20/22] git-remote-mediawiki: Put non-trivial numeric values in constants Célestin Matte
2013-06-07 21:42 ` [PATCH v2 21/22] git-remote-mediawiki: Fix a typo ("mediwiki" instead of "mediawiki") Célestin Matte
2013-06-07 21:42 ` [PATCH v2 22/22] git-remote-mediawiki: Clearly rewrite double dereference Célestin Matte
2013-06-07 23:34 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B37BB0.7000504@ensimag.fr \
--to=celestin.matte@ensimag.fr \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=benoit.person@ensimag.fr \
--cc=git@vger.kernel.org \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).