From: "Célestin Matte" <celestin.matte@ensimag.fr>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: "Célestin Matte" <celestin.matte@ensimag.fr>,
git@vger.kernel.org, benoit.person@ensimag.fr
Subject: Re: [PATCH] git-remote-mediawiki: Fix a bug in a regexp
Date: Sat, 08 Jun 2013 22:08:36 +0200 [thread overview]
Message-ID: <51B38F44.6080304@ensimag.fr> (raw)
In-Reply-To: <vpqmwr0v45b.fsf@anie.imag.fr>
Le 08/06/2013 20:38, Matthieu Moy a écrit :> This is right, but the code
actually worked the way it was. I'm not
> sure, but my understanding is that '\n' is the string "backslash
> followed by n", but interpreted as a regexp, it is a newline.
>
> The new code looks better than the old one, but the log message may be
> improved.
Is this better?
"
In Perl, '\n' is not a newline, but instead the string composed of a
backslash followed by an "n". To match newlines, one has to use the /\n/
regexp. As the output of "rev-list --first-parent" is line-oriented,
what we want here is to match newlines, and not the "\n" string.
"
--
Célestin Matte
next prev parent reply other threads:[~2013-06-08 20:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-08 13:35 [PATCH] git-remote-mediawiki: Fix a bug in a regexp Célestin Matte
2013-06-08 18:38 ` Matthieu Moy
2013-06-08 20:08 ` Célestin Matte [this message]
2013-06-09 2:57 ` Jeff King
2013-06-09 5:21 ` Eric Sunshine
2013-06-09 5:11 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B38F44.6080304@ensimag.fr \
--to=celestin.matte@ensimag.fr \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=benoit.person@ensimag.fr \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).