From: Johannes Sixt <j6t@kdbg.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Ramkumar Ramachandra <artagnon@gmail.com>,
Git List <git@vger.kernel.org>
Subject: Re: [PATCH 08/16] t/t5516-fetch-push: use test_config()
Date: Sat, 22 Jun 2013 11:57:59 +0200 [thread overview]
Message-ID: <51C57527.8060806@kdbg.org> (raw)
In-Reply-To: <7vobazjdrf.fsf@alter.siamese.dyndns.org>
Am 22.06.2013 00:32, schrieb Junio C Hamano:
> Ramkumar Ramachandra <artagnon@gmail.com> writes:
>
>> Replace the 'git config' calls in tests with test_config for greater
>> robustness.
>
> That may be a good thing in principle, but I _think_
>
> mk_empty testrepo &&
> (
> cd testrepo &&
> do whatever to its config &&
> run test
> )
>
> sequence is used so that we do not even have to worry about what
> leftover configuration values are in the testrepo/.git/config; so
> does it really matter?
>
> If this conversion had something more than "s/git config/test_config/"
> replacement, that would indicate that you uncovered a bug in the
> existing test and found a good fix, but that does not seem to be the
> case for this particular patch.
And just let me add that the added benefit of test_config to remove the
configuration change after the test case finished would not work because
the test_when_finished registration that happens behind the scenes would
be forgotten when the sub-shell exits.
>> @@ -142,8 +142,8 @@ test_expect_success 'fetch with wildcard' '
>> mk_empty testrepo &&
>> (
>> cd testrepo &&
>> - git config remote.up.url .. &&
>> - git config remote.up.fetch "refs/heads/*:refs/remotes/origin/*" &&
>> + test_config remote.up.url .. &&
>> + test_config remote.up.fetch "refs/heads/*:refs/remotes/origin/*" &&
>> git fetch up &&
...
-- Hannes
next prev parent reply other threads:[~2013-06-22 9:58 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 11:12 [PATCH 00/16] Cleanup {branches,remotes}-file cruft Ramkumar Ramachandra
2013-06-21 11:12 ` [PATCH 01/16] t/t5505-remote: modernize subshell-style of one test Ramkumar Ramachandra
2013-06-21 22:04 ` Junio C Hamano
2013-06-22 6:24 ` Ramkumar Ramachandra
2013-06-21 11:12 ` [PATCH 02/16] t/t5505-remote: test push-refspec in branches-file Ramkumar Ramachandra
2013-06-21 22:08 ` Junio C Hamano
2013-06-21 11:12 ` [PATCH 03/16] t/t5505-remote: use test_path_is_missing Ramkumar Ramachandra
2013-06-21 11:12 ` [PATCH 04/16] t/t5505-remote: remove dependency on $origin_url Ramkumar Ramachandra
2013-06-21 22:10 ` Junio C Hamano
2013-06-22 6:27 ` Ramkumar Ramachandra
2013-06-22 21:10 ` Junio C Hamano
2013-06-23 7:51 ` Ramkumar Ramachandra
2013-06-21 11:12 ` [PATCH 05/16] remote: remove dead code in read_branches_file() Ramkumar Ramachandra
2013-06-21 22:26 ` Junio C Hamano
2013-06-22 7:36 ` Ramkumar Ramachandra
2013-06-23 8:07 ` Junio C Hamano
2013-06-23 8:37 ` Ramkumar Ramachandra
2013-06-23 21:15 ` Junio C Hamano
2013-06-21 11:12 ` [PATCH 06/16] t/t5505-remote: test url-with-# in branches-file Ramkumar Ramachandra
2013-06-21 22:28 ` Junio C Hamano
2013-06-22 7:16 ` Ramkumar Ramachandra
2013-06-21 11:12 ` [PATCH 07/16] t/t5516-fetch-push: don't use branches-file Ramkumar Ramachandra
2013-06-21 22:29 ` Junio C Hamano
2013-06-21 11:12 ` [PATCH 08/16] t/t5516-fetch-push: use test_config() Ramkumar Ramachandra
2013-06-21 22:32 ` Junio C Hamano
2013-06-22 7:15 ` Ramkumar Ramachandra
2013-06-22 9:57 ` Johannes Sixt [this message]
2013-06-21 11:12 ` [PATCH 09/16] ls-remote doc: fix example invocation on git.git Ramkumar Ramachandra
2013-06-21 22:38 ` Junio C Hamano
2013-06-21 11:12 ` [PATCH 10/16] ls-remote doc: rewrite <repository> paragraph Ramkumar Ramachandra
2013-06-21 22:39 ` Junio C Hamano
2013-06-21 11:12 ` [PATCH 11/16] ls-remote doc: don't encourage use of branches-file Ramkumar Ramachandra
2013-06-21 11:12 ` [PATCH 12/16] t/t5505-remote: modernize subshell-style of one test Ramkumar Ramachandra
2013-06-21 11:12 ` [PATCH 13/16] t/t5505-remote: test multiple push/pull in remotes-file Ramkumar Ramachandra
2013-06-21 22:53 ` Eric Sunshine
2013-06-22 7:41 ` Ramkumar Ramachandra
2013-06-21 11:12 ` [PATCH 14/16] t/t5510-fetch: don't use remotes-file Ramkumar Ramachandra
2013-06-21 11:12 ` [PATCH 15/16] t/t5515-fetch-merge-logic: don't use {branches,remotes}-file Ramkumar Ramachandra
2013-06-21 11:12 ` [PATCH 16/16] remote: deprecate read_{branches,remotes}_file Ramkumar Ramachandra
2013-06-21 14:32 ` [PATCH 00/16] Cleanup {branches,remotes}-file cruft Junio C Hamano
2013-06-21 16:22 ` Ramkumar Ramachandra
2013-06-21 16:33 ` Junio C Hamano
2013-06-21 19:09 ` Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51C57527.8060806@kdbg.org \
--to=j6t@kdbg.org \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).