From: Mark Levedahl <mlevedahl@gmail.com>
To: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Use compat/regex on Cygwin
Date: Tue, 16 Jul 2013 19:24:01 -0400 [thread overview]
Message-ID: <51E5D611.7000300@gmail.com> (raw)
In-Reply-To: <51E5BE08.9060304@ramsay1.demon.co.uk>
On 07/16/2013 05:41 PM, Ramsay Jones wrote:
> Mark Levedahl wrote:
>> Cygwin's regex library does not pass git's tests, so don't use it. This
>> fixes failures in t4018 and t4034.
> Hmm, these tests have always passed for me on cygwin. So, this is
> presumably a regression in the new-lib regex library versions used
> by cygwin 1.5 and cygwin 1.7.
>
> ATB,
> Ramsay Jones
>
>
>
Yes, cygwin 1.7 now uses the newlib regex functions, and those are not
quite up to snuff. Another case for calling 1.5 a separate platform
altogether.
Mark
prev parent reply other threads:[~2013-07-16 23:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-15 14:10 [PATCH] Use compat/regex on Cygwin Mark Levedahl
2013-07-16 21:41 ` Ramsay Jones
2013-07-16 22:03 ` Mark Levedahl
2013-07-16 23:24 ` Mark Levedahl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51E5D611.7000300@gmail.com \
--to=mlevedahl@gmail.com \
--cc=git@vger.kernel.org \
--cc=ramsay@ramsay1.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).