* [PATCH] Use compat/regex on Cygwin
@ 2013-07-15 14:10 Mark Levedahl
2013-07-16 21:41 ` Ramsay Jones
0 siblings, 1 reply; 4+ messages in thread
From: Mark Levedahl @ 2013-07-15 14:10 UTC (permalink / raw)
To: git; +Cc: Mark Levedahl
Cygwin's regex library does not pass git's tests, so don't use it. This
fixes failures in t4018 and t4034.
Signed-off-by: Mark Levedahl <mlevedahl@gmail.com>
---
config.mak.uname | 1 +
1 file changed, 1 insertion(+)
diff --git a/config.mak.uname b/config.mak.uname
index 7ac541e..6901597 100644
--- a/config.mak.uname
+++ b/config.mak.uname
@@ -165,6 +165,7 @@ ifeq ($(uname_O),Cygwin)
NO_FAST_WORKING_DIRECTORY = UnfortunatelyYes
NO_TRUSTABLE_FILEMODE = UnfortunatelyYes
NO_ST_BLOCKS_IN_STRUCT_STAT = YesPlease
+ NO_REGEX = UnfortunatelyYes
# There are conflicting reports about this.
# On some boxes NO_MMAP is needed, and not so elsewhere.
# Try commenting this out if you suspect MMAP is more efficient
--
1.8.3.2.0.13
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Use compat/regex on Cygwin
2013-07-15 14:10 [PATCH] Use compat/regex on Cygwin Mark Levedahl
@ 2013-07-16 21:41 ` Ramsay Jones
2013-07-16 22:03 ` Mark Levedahl
2013-07-16 23:24 ` Mark Levedahl
0 siblings, 2 replies; 4+ messages in thread
From: Ramsay Jones @ 2013-07-16 21:41 UTC (permalink / raw)
To: Mark Levedahl; +Cc: git
Mark Levedahl wrote:
> Cygwin's regex library does not pass git's tests, so don't use it. This
> fixes failures in t4018 and t4034.
Hmm, these tests have always passed for me on cygwin. So, this is
presumably a regression in the new-lib regex library versions used
by cygwin 1.5 and cygwin 1.7.
ATB,
Ramsay Jones
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Use compat/regex on Cygwin
2013-07-16 21:41 ` Ramsay Jones
@ 2013-07-16 22:03 ` Mark Levedahl
2013-07-16 23:24 ` Mark Levedahl
1 sibling, 0 replies; 4+ messages in thread
From: Mark Levedahl @ 2013-07-16 22:03 UTC (permalink / raw)
To: Ramsay Jones; +Cc: git
On 07/16/2013 05:41 PM, Ramsay Jones wrote:
> Mark Levedahl wrote:
>> Cygwin's regex library does not pass git's tests, so don't use it. This
>> fixes failures in t4018 and t4034.
> Hmm, these tests have always passed for me on cygwin. So, this is
> presumably a regression in the new-lib regex library versions used
> by cygwin 1.5 and cygwin 1.7.
>
> ATB,
> Ramsay Jones
>
>
>
Perhaps we should just completely separate cygwin 1.5 settings from
those for current cygwin. Extra motivation is that cygwin 1.5 is no
longer on the mirrors - the last real update was mid 2009, and the
project finally removed the installation tree altogether.
Mark
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Use compat/regex on Cygwin
2013-07-16 21:41 ` Ramsay Jones
2013-07-16 22:03 ` Mark Levedahl
@ 2013-07-16 23:24 ` Mark Levedahl
1 sibling, 0 replies; 4+ messages in thread
From: Mark Levedahl @ 2013-07-16 23:24 UTC (permalink / raw)
To: Ramsay Jones; +Cc: git
On 07/16/2013 05:41 PM, Ramsay Jones wrote:
> Mark Levedahl wrote:
>> Cygwin's regex library does not pass git's tests, so don't use it. This
>> fixes failures in t4018 and t4034.
> Hmm, these tests have always passed for me on cygwin. So, this is
> presumably a regression in the new-lib regex library versions used
> by cygwin 1.5 and cygwin 1.7.
>
> ATB,
> Ramsay Jones
>
>
>
Yes, cygwin 1.7 now uses the newlib regex functions, and those are not
quite up to snuff. Another case for calling 1.5 a separate platform
altogether.
Mark
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-07-16 23:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-15 14:10 [PATCH] Use compat/regex on Cygwin Mark Levedahl
2013-07-16 21:41 ` Ramsay Jones
2013-07-16 22:03 ` Mark Levedahl
2013-07-16 23:24 ` Mark Levedahl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).