From: Drew Northup <n1xim.email@gmail.com>
To: Jonas Fonseca <fonseca@diku.dk>
Cc: git <git@vger.kernel.org>
Subject: Re: [PATCH] TIG: Fix to reinstate proper operation with no arguments
Date: Wed, 24 Jul 2013 08:29:37 -0400 [thread overview]
Message-ID: <51EFC8B1.20405@gmail.com> (raw)
In-Reply-To: <CAFuPQ1K=hWUSCEhaGsuW8PeoGQcj6AoPo61zUTDbjLE802h+7g@mail.gmail.com>
On 07/19/2013 12:07 AM, Jonas Fonseca wrote:
> On Thu, Jul 18, 2013 at 9:30 AM, Drew Northup<n1xim.email@gmail.com> wrote:
>>
>> Somehow this patch breaks the main view to not open the correct commit in diff view when<enter> is pressed. Back to the debugger...
>
> Does this (possibly white-space damaged) patch work for you?
It does, but I prefer to actually fix the problem this highlights and
not to paper it over. Patch V2 will be on the way shortly.
> diff --git a/tig.c b/tig.c
> index ba9ba98..74a2928 100644
> --- a/tig.c
> +++ b/tig.c
> @@ -3104,7 +3104,7 @@ format_expand_arg(struct format_context *format,
> const char *name)
> static bool
> format_append_arg(struct format_context *format, const char
> ***dst_argv, const char *arg)
> {
> - format->bufpos = 0;
> + format->buf[0] = format->bufpos = 0;
>
> while (arg) {
> char *next = strstr(arg, "%(");
>
>
> --
> Jonas Fonseca
--
--
-Drew Northup
--------------------------------------------------------------
"As opposed to vegetable or mineral error?"
-John Pescatore, SANS NewsBites Vol. 12 Num. 59
next prev parent reply other threads:[~2013-07-24 12:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-18 4:51 [PATCH] TIG: Fix to reinstate proper operation with no arguments Drew Northup
2013-07-18 13:30 ` Drew Northup
2013-07-19 4:07 ` Jonas Fonseca
2013-07-19 11:55 ` Drew Northup
2013-07-24 12:29 ` Drew Northup [this message]
2013-07-24 12:50 ` [PATCH V2] " Drew Northup
2013-07-29 1:23 ` Jonas Fonseca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51EFC8B1.20405@gmail.com \
--to=n1xim.email@gmail.com \
--cc=fonseca@diku.dk \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).