From: Stefan Beller <stefanbeller@googlemail.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/4] log, format-patch: accept short parameter 'q' for quiet
Date: Wed, 31 Jul 2013 12:35:08 +0200 [thread overview]
Message-ID: <51F8E85C.9050904@googlemail.com> (raw)
In-Reply-To: <51F6E71A.8050109@web.de>
[-- Attachment #1: Type: text/plain, Size: 673 bytes --]
On 07/30/13 00:05, René Scharfe wrote:
> Am 29.07.2013 21:49, schrieb Stefan Beller:
>> const struct option builtin_log_options[] = {
>> - OPT_BOOL(0, "quiet", &quiet, N_("suppress diff output")),
>> + OPT_BOOL('q', "quiet", &quiet, N_("suppress diff output")),
>
> You can shorten it using OPT__QUIET. But that macro should be converted
> to OPT_BOOL first, in turn. Unless --verbose, for which it sometimes
> makes sense to print ever more output the more often it is specified, I
> wouldn't expect there to be a command with different levels of
> quietness, but didn't check.
>
Thanks for the hint.
I'll look into that as well.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 899 bytes --]
next prev parent reply other threads:[~2013-07-31 10:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 19:49 [PATCH 0/4] Removing deprecated parsing macros Stefan Beller
2013-07-29 19:49 ` [PATCH 1/4] Replace deprecated OPT_BOOLEAN by OPT_BOOL Stefan Beller
2013-07-29 19:49 ` [PATCH 2/4] log, format-patch: accept short parameter 'q' for quiet Stefan Beller
2013-07-29 22:05 ` René Scharfe
2013-07-31 10:35 ` Stefan Beller [this message]
2013-07-29 19:49 ` [PATCH 3/4] checkout: remove superfluous local variable Stefan Beller
2013-07-29 19:49 ` [PATCH 4/4] name-rev: ease up condition Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51F8E85C.9050904@googlemail.com \
--to=stefanbeller@googlemail.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).