From: "Yann Dirson" <ydirson@linagora.com>
To: "Jeff King" <peff@peff.net>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Yann Dirson" <ydirson@linagora.com>,
git@vger.kernel.org
Subject: Re: [BUG] git stash refuses to save after "add -N"
Date: Mon, 31 Aug 2009 10:16:34 +0200 [thread overview]
Message-ID: <51ce4af01c8de1adb66a1818baab1f8a.squirrel@intranet.linagora.com> (raw)
In-Reply-To: <20090831050554.GA17197@coredump.intra.peff.net>
> On Sun, Aug 30, 2009 at 10:03:07PM -0700, Junio C Hamano wrote:
>
>> > - "-f" is kind of vague. Would people expect it to force aspects of
>> > the stash? Should it be "--intent-as-empty"?
>>
>> I am not sure if asking for positive confirmation with "-f" is even
>> worth
>> it. As you pointed out in your earlier message, which prompted me to
>> respond with a patch, when this codepath is exercised, the user is in a
>> rush, and I do not see what else the user would want to do other than
>> including it in the stash by rerunning with -f.
>
> I guess it was just to mitigate my fear that we are somehow creating a
> stash that will confuse people when they apply it. But really that fear
> is probably unjustified.
Well, indeed each time I use "add -N" it is mostly to get "git diff" show
me the contents of the new file as part of my WIP, so it would not make
much difference to me if "add -N" would just add the file as empty to the
index in the first place.
Out of curiosity, does anyone make any use of the current difference
between not-added-yet and added-as-empty ?
next prev parent reply other threads:[~2009-08-31 8:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-28 11:02 [BUG] git stash refuses to save after "add -N" Yann Dirson
2009-08-28 19:05 ` Jeff King
2009-08-28 19:22 ` Jeff King
2009-08-29 22:34 ` Junio C Hamano
2009-08-30 9:55 ` Jeff King
2009-08-30 20:01 ` Junio C Hamano
2009-08-31 4:27 ` Jeff King
2009-08-31 5:03 ` Junio C Hamano
2009-08-31 5:05 ` Jeff King
2009-08-31 8:16 ` Yann Dirson [this message]
2009-08-31 4:36 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51ce4af01c8de1adb66a1818baab1f8a.squirrel@intranet.linagora.com \
--to=ydirson@linagora.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).