From: Derrick Stolee <derrickstolee@github.com>
To: Elijah Newren <newren@gmail.com>, Junio C Hamano <gitster@pobox.com>
Cc: "Git Mailing List" <git@vger.kernel.org>,
"Eric Sunshine" <sunshine@sunshineco.com>,
"Jean-Noël AVILA" <jn.avila@free.fr>
Subject: Re: ds/sparse-checkout-requires-per-worktree-config (Was: Re: What's cooking in git.git (Feb 2022, #04; Tue, 15))
Date: Wed, 16 Feb 2022 08:54:05 -0500 [thread overview]
Message-ID: <51efdb1e-00f1-e4c0-97df-478cc5982b49@github.com> (raw)
In-Reply-To: <CABPp-BHxg+KE7W0jLfHC+DfjRyNoigv4qSEgJyehnUZNLUzZCg@mail.gmail.com>
On 2/16/2022 12:06 AM, Elijah Newren wrote:
> On Tue, Feb 15, 2022 at 12:01 PM Junio C Hamano <gitster@pobox.com> wrote:
>>
>> * ds/sparse-checkout-requires-per-worktree-config (2022-02-08) 6 commits
>> - config: make git_configset_get_string_tmp() private
>> - worktree: copy sparse-checkout patterns and config on add
>> - sparse-checkout: set worktree-config correctly
>> - config: add repo_config_set_worktree_gently()
>> - worktree: create init_worktree_config()
>> - Documentation: add extensions.worktreeConfig details
>>
>> "git sparse-checkout" wants to work with per-worktree configration,
>> but did not work well in a worktree attached to a bare repository.
>>
>> Will merge to 'next'?
>> cf. <20220204081336.3194538-1-newren@gmail.com>
>> cf. <CAPig+cRrRxuTeByhKkLs_KDaWY8-r4+jrwT83A-r+sBQsmebMw@mail.gmail.com>
>> source: <pull.1101.v6.git.1644269583.gitgitgadget@gmail.com>
>
> With v6, Eric seems to also be happy with the series (cf.
> <CAPig+cQTRGuuspz2g5LZr4Oh8bQCr4FUDV0tirs+ZPwhtAaJVw@mail.gmail.com>).
> So, I think it's ready to merge down.
I agree. Thanks for the close looks at this.
I think I will send a forward fix that attempts to clear up
the "worktree" versus "working tree" changes across all of
git-worktree.txt and related docs, now that Eric corrected my
interpretation of his comments [1].
Thanks,
-Stolee
[1] https://lore.kernel.org/git/CAPig+cR+n=LQg5AJQgGQXuYStN90-jExWnE45sS1EXo+O8dQgQ@mail.gmail.com/
prev parent reply other threads:[~2022-02-16 13:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 17:25 What's cooking in git.git (Feb 2022, #04; Tue, 15) Junio C Hamano
2022-02-15 22:17 ` ja/i18n-common-messages (was: What's cooking in git.git (Feb 2022, #04; Tue, 15)) Ævar Arnfjörð Bjarmason
2022-02-15 22:22 ` ab/ambiguous-object-name & ab/only-single-progress-at-once " Ævar Arnfjörð Bjarmason
2022-02-16 4:52 ` en/present-despite-skipped (Was: " Elijah Newren
2022-02-16 9:44 ` Ævar Arnfjörð Bjarmason
2022-02-16 16:38 ` Elijah Newren
2022-02-16 5:01 ` js/apply-partial-clone-filters-recursively " Elijah Newren
2022-02-16 5:06 ` ds/sparse-checkout-requires-per-worktree-config " Elijah Newren
2022-02-16 13:54 ` Derrick Stolee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51efdb1e-00f1-e4c0-97df-478cc5982b49@github.com \
--to=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jn.avila@free.fr \
--cc=newren@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).