From: "René Scharfe" <l.s.r@web.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org,
"Felipe Contreras" <felipe.contreras@gmail.com>,
"Лежанкин Иван" <abyss.7@gmail.com>
Subject: Re: [PATCH] unpack-trees: plug a memory leak
Date: Tue, 13 Aug 2013 23:32:46 +0200 [thread overview]
Message-ID: <520AA5FE.1090208@web.de> (raw)
In-Reply-To: <7va9klwb03.fsf@alter.siamese.dyndns.org>
Am 13.08.2013 23:12, schrieb Junio C Hamano:
> René Scharfe <l.s.r@web.de> writes:
>
>> From: Felipe Contreras <felipe.contreras@gmail.com>
>>
>> Before overwriting the destination index, first let's discard its
>> contents.
>>
>> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>> Tested-by: Лежанкин Иван <abyss.7@gmail.com> wrote:
>> ---
>> Felipe sent this patch as part of multiple series in June, but it can
>> stand on its own. This version is trivially rebased against master.
>> The leak seems to have been introduced by 34110cd4 (2008-03-06,
>> "Make 'unpack_trees()' have a separate source and destination index").
>
> It was lost in the follow-up discussion and I missed it.
I had forgotten about it as well, until Felipe mentioned it again.
> I assume that this is signed-off by you as a forwarder? I'd prefer
> to even mark it Reviewed-by: you.
Right, I did review the patch and you can tag it as such.
Thanks,
René
next prev parent reply other threads:[~2013-08-13 21:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 12:13 Huge possible memory leak while cherry-picking Лежанкин Иван
2013-08-09 20:39 ` Felipe Contreras
2013-08-12 10:04 ` Лежанкин Иван
2013-08-12 10:09 ` Felipe Contreras
2013-08-13 18:27 ` [PATCH] unpack-trees: plug a memory leak René Scharfe
2013-08-13 21:12 ` Junio C Hamano
2013-08-13 21:32 ` René Scharfe [this message]
2013-08-13 21:50 ` Junio C Hamano
2013-08-12 10:34 ` Huge possible memory leak while cherry-picking Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520AA5FE.1090208@web.de \
--to=l.s.r@web.de \
--cc=abyss.7@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).