From: Stephen Hemminger <stephen.hemminger@vyatta.com>
To: Lasse Makholm <lasse.makholm@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: git svn perl issues
Date: Wed, 23 Mar 2011 14:45:35 -0700 (PDT) [thread overview]
Message-ID: <521251622.25680.1300916735091.JavaMail.root@tahiti.vyatta.com> (raw)
In-Reply-To: <AANLkTikowuFsXFwLL14oS0zzHh3RiHOrGTVHXgyy8dLw@mail.gmail.com>
> On 23 March 2011 16:52, Stephen Hemminger <shemminger@vyatta.com>
> wrote:
> > 1. The following needs to be fixed:
> >
> > $ git svn clone
> > Use of uninitialized value $_[0] in substitution (s///) at
> > /usr/share/perl/5.10.1/File/Basename.pm line 341.
> > fileparse(): need a valid pathname at /usr/lib/git-core/git-svn line
> > 403
>
> While noisy and ugly, uninitialized warnings are usually pretty
> harmless...
User should never see perl splat, it is sloppy.
> > 2. The git-svn perl script does not follow Perl Best Practices.
> > If you run the perlcritic script on it, all the following
> > warnings/errors
> > are generated:
>
> Some of these are undoubtedly valid complaints, but the so called best
> practices that the perl critic policies implement are, in my opinion,
> not widely accepted as such by the perl community. At least not all of
> them. I wouldn't go following them blindly - especially in working
> production code...
Some of them are crap, but like sparse warnings it is trivial to
fix them and make it clean so why not.
If you don't maintain code it just rots.
next prev parent reply other threads:[~2011-03-23 21:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-23 15:52 git svn perl issues Stephen Hemminger
2011-03-23 21:38 ` Lasse Makholm
2011-03-23 21:45 ` Stephen Hemminger [this message]
2011-03-23 22:19 ` Lasse Makholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521251622.25680.1300916735091.JavaMail.root@tahiti.vyatta.com \
--to=stephen.hemminger@vyatta.com \
--cc=git@vger.kernel.org \
--cc=lasse.makholm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).