From: "René Scharfe" <l.s.r@web.de>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] branch: use $curr_branch_short more
Date: Sat, 31 Aug 2013 11:11:00 +0200 [thread overview]
Message-ID: <5221B324.7020908@web.de> (raw)
In-Reply-To: <CAMP44s1qyF70eSCM4L1Yr=U02AwFZ0TNqiDvag8Qdzzi9GS1Mw@mail.gmail.com>
Am 31.08.2013 10:22, schrieb Felipe Contreras:
>> Subject: branch: use $curr_branch_short more
>
> Why? I don't think that summary explains the reason for being for this
> patch, also, it starts with branch: instead of pull:
You're right about "branch" vs. "pull". I'll better go back to bed. ~_~
> Subject: pull: trivial simplification
>
> With that summary, people would have an easier time figuring out if
> they need to read more about the patch or not.
"trivial simplification" is too generic; we could have lots of them. A
summary should describe the change. Its low complexity can be derived
from it -- using an existing variable a bit more is not very exciting.
But I wouldn't call that patch trivial because its correctness depends
on code outside of its shown context.
The reason for the patch isn't mentioned explicitly. Perhaps it should
be. I felt that using something that's already there instead of
recreating it is motivation alone.
René
next prev parent reply other threads:[~2013-08-31 9:11 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-30 21:56 [PATCH 0/6] Trivial cleanups and fixes Felipe Contreras
2013-08-30 21:56 ` [PATCH 1/6] reset: trivial refactoring Felipe Contreras
2013-08-31 3:36 ` Junio C Hamano
2013-08-30 21:56 ` [PATCH 2/6] branch: trivial style fix Felipe Contreras
2013-08-31 3:36 ` Junio C Hamano
2013-08-30 21:56 ` [PATCH 3/6] rebase: trivial style fixes Felipe Contreras
2013-08-31 3:49 ` Junio C Hamano
2013-08-30 21:56 ` [PATCH 4/6] reset: trivial style cleanup Felipe Contreras
2013-08-31 3:49 ` Junio C Hamano
2013-08-30 21:56 ` [PATCH 5/6] add: " Felipe Contreras
2013-08-31 3:37 ` Junio C Hamano
2013-08-30 21:56 ` [PATCH 6/6] pull: trivial cleanup Felipe Contreras
2013-08-31 3:58 ` Junio C Hamano
2013-08-31 7:56 ` Felipe Contreras
2013-08-31 8:10 ` [PATCH] branch: use $curr_branch_short more René Scharfe
2013-08-31 8:22 ` Felipe Contreras
2013-08-31 9:11 ` René Scharfe [this message]
2013-08-31 9:22 ` Felipe Contreras
2013-08-31 10:28 ` René Scharfe
2013-08-31 17:20 ` Felipe Contreras
2013-09-08 15:21 ` René Scharfe
2013-09-08 23:13 ` Felipe Contreras
2013-09-15 11:42 ` René Scharfe
2013-09-15 13:02 ` Felipe Contreras
2013-09-03 16:56 ` Junio C Hamano
2013-09-08 15:21 ` [PATCH] pull: " René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5221B324.7020908@web.de \
--to=l.s.r@web.de \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).