git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Mallon <christoph.mallon@gmx.de>
To: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Bug in git rebase --continue in v1.8.4
Date: Sat, 31 Aug 2013 14:49:37 +0200	[thread overview]
Message-ID: <5221E661.1070200@gmx.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 984 bytes --]

Hi,

if I run rebase --continue (e.g. after a conflict resolution), then the rebase always ends with this error message:
	It seems that there is already a rebase-apply directory, and
	I wonder if you are in the middle of another rebase.  If that is the
	case, please try
        	git rebase (--continue | --abort | --skip)
	If that is not the case, please
        	rm -fr "/home/tron/gitRebaseTest/test/.git/rebase-apply"
	and run me again.  I am stopping in case you still have something
	valuable there.

This happens on git v1.8.4 on FreeBSD. It is fine with v1.8.3.4. It seems to be caused by a1549e1049439386b9fd643fae236ad3ba649650, specifically this hunk:
	--- a/git-rebase--am.sh
	+++ b/git-rebase--am.sh
	@@ -7,12 +7,12 @@ case "$action" in
	 continue)
	  git am --resolved --resolvemsg="$resolvemsg" &&
	  move_to_original_branch
	- exit
	+ return
	  ;;
	 skip)
	  git am --skip --resolvemsg="$resolvemsg" &&

Attached is a test script for this problem.

Regards
	Christoph

[-- Attachment #2: gitRebaseTest --]
[-- Type: text/plain, Size: 274 bytes --]

#! /bin/sh
set -eux

git init test
cd test

echo a > file
git add .
git commit -m a

git branch -t test

echo b > file
git add .
git commit -m b

git checkout test
echo c > file
git add .
git commit -m c

! git rebase
git checkout --theirs .
git add .
git rebase --continue

             reply	other threads:[~2013-08-31 12:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-31 12:49 Christoph Mallon [this message]
2013-09-04  8:02 ` Bug in git rebase --continue in v1.8.4 Andriy Gapon
2013-09-04  8:18   ` Matthieu Moy
2013-09-04  8:53     ` Andriy Gapon
2013-09-04  9:17       ` Andriy Gapon
2013-09-04 11:56         ` Matthieu Moy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5221E661.1070200@gmx.de \
    --to=christoph.mallon@gmx.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).