From: Andriy Gapon <avg@FreeBSD.org>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: git@vger.kernel.org, Ramkumar Ramachandra <artagnon@gmail.com>
Subject: Re: Bug in git rebase --continue in v1.8.4
Date: Wed, 04 Sep 2013 11:53:12 +0300 [thread overview]
Message-ID: <5226F4F8.7090304@FreeBSD.org> (raw)
In-Reply-To: <vpqsixl9ezo.fsf@anie.imag.fr>
on 04/09/2013 11:18 Matthieu Moy said the following:
> [ Cc-ing Ram, as he is the author of the possibly guilty commit. ]
>
> Andriy Gapon <avg@FreeBSD.org> writes:
>> Judging by the lack of followups, could this be a FreeBSD-specific problem?
>
> I can't reproduce here (Debian GNU/Linux). Do the testsuite pass for
> you?
>
> If not, can you write a failing test? A minimalist script outside the
> testsuite may help too if you're not familiar with Git's testsuite.
Thank you for the suggestion.
I've just tried it and it failed here:
*** t3403-rebase-skip.sh ***
ok 1 - setup
ok 2 - rebase with git am -3 (default)
ok 3 - rebase --skip can not be used with other options
not ok 4 - rebase --skip with am -3
#
# git rebase --skip
#
not ok 5 - rebase moves back to skip-reference
#
# test refs/heads/skip-reference = $(git symbolic-ref HEAD) &&
# git branch post-rebase &&
# git reset --hard pre-rebase &&
# test_must_fail git rebase master &&
# echo "hello" > hello &&
# git add hello &&
# git rebase --continue &&
# test refs/heads/skip-reference = $(git symbolic-ref HEAD) &&
# git reset --hard post-rebase
#
ok 6 - checkout skip-merge
ok 7 - rebase with --merge
not ok 8 - rebase --skip with --merge
#
# git rebase --skip
#
ok 9 - merge and reference trees equal
not ok 10 - moved back to branch correctly
#
# test refs/heads/skip-merge = $(git symbolic-ref HEAD)
#
# failed 4 among 10 test(s)
Christoph has also suggested a small test script in his original email that
started this thread:
http://thread.gmane.org/gmane.comp.version-control.git/233516
--
Andriy Gapon
next prev parent reply other threads:[~2013-09-04 8:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-31 12:49 Bug in git rebase --continue in v1.8.4 Christoph Mallon
2013-09-04 8:02 ` Andriy Gapon
2013-09-04 8:18 ` Matthieu Moy
2013-09-04 8:53 ` Andriy Gapon [this message]
2013-09-04 9:17 ` Andriy Gapon
2013-09-04 11:56 ` Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5226F4F8.7090304@FreeBSD.org \
--to=avg@freebsd.org \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).