From: Chris Packham <judge.packham@gmail.com>
To: Tay Ray Chuan <rctay89@gmail.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH 3/3] git submodule update should give notice when run without init beforehand
Date: Thu, 19 Sep 2013 22:25:27 +1200 [thread overview]
Message-ID: <523AD117.20109@gmail.com> (raw)
In-Reply-To: <CALUzUxrf+ZGX8nQ0DVqYEyWto3Cos16VLTUfjsX99qnDLa=S6w@mail.gmail.com>
On 18/09/13 22:22, Tay Ray Chuan wrote:
> Hi Chris,
>
> I think you mentioned usability issues with git-submodule before on
> the git mailing list, so I thought you might be interested in taking a
> look at this patch. It's attached below, you can also view it at
>
> http://thread.gmane.org/gmane.comp.version-control.git/1379266703-29808-3-git-send-email-rctay89@gmail.com
>
> I would be interested in hearing what you think.
>
The case I had was that an un-init'd submodule was still a directory on
the file system so 'cd submodule' would work and it could go unnoticed
that we hadn't entered the submodule.
Your change might have helped somewhat but the bigger problem was that
the work-tree representation of an un-init'd submodule is a directory.
There was never any thought to actually run 'git submodule update'
because the developer in question thought they already had.
I think Jens' autoinit may be the right direction. It certainly would be
what we'd want for our use-case at $dayjob.
prev parent reply other threads:[~2013-09-19 10:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-15 17:38 [PATCH 1/3] t7406-submodule-update: add missing && Tay Ray Chuan
2013-09-15 17:38 ` [PATCH 2/3] t7406-submodule-update: demonstrate behaviour when run without init beforehand Tay Ray Chuan
2013-09-15 17:38 ` [PATCH 3/3] git submodule update should give notice " Tay Ray Chuan
2013-09-16 17:06 ` Jens Lehmann
2013-09-18 10:12 ` Tay Ray Chuan
2013-09-18 19:13 ` Jens Lehmann
[not found] ` <CALUzUxrf+ZGX8nQ0DVqYEyWto3Cos16VLTUfjsX99qnDLa=S6w@mail.gmail.com>
2013-09-19 10:25 ` Chris Packham [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523AD117.20109@gmail.com \
--to=judge.packham@gmail.com \
--cc=git@vger.kernel.org \
--cc=rctay89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).