From: Richard Hansen <rhansen@bbn.com>
To: Felipe Contreras <felipe.contreras@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 4/9] fast-export: add new --refspec option
Date: Sun, 22 Sep 2013 21:59:24 -0400 [thread overview]
Message-ID: <523FA07C.9040909@bbn.com> (raw)
In-Reply-To: <1377789808-2213-5-git-send-email-felipe.contreras@gmail.com>
On 2013-08-29 11:23, Felipe Contreras wrote:
> So that we can covert the exported ref names.
>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
> Documentation/git-fast-export.txt | 4 ++++
> builtin/fast-export.c | 30 ++++++++++++++++++++++++++++++
> t/t9350-fast-export.sh | 7 +++++++
> 3 files changed, 41 insertions(+)
>
> diff --git a/Documentation/git-fast-export.txt b/Documentation/git-fast-export.txt
> index 85f1f30..221506b 100644
> --- a/Documentation/git-fast-export.txt
> +++ b/Documentation/git-fast-export.txt
> @@ -105,6 +105,10 @@ marks the same across runs.
> in the commit (as opposed to just listing the files which are
> different from the commit's first parent).
>
> +--refspec::
> + Apply the specified refspec to each ref exported. Multiple of them can
> + be specified.
> +
Do you mean '--refspec=<refspec>' and/or '--refspec <refspec>'?
How are the multiple refspecs specified? Space/comma/colon separated
list? Or multiple '--refspec' arguments with one refspec per '--refspec'?
> diff --git a/t/t9350-fast-export.sh b/t/t9350-fast-export.sh
> index 34c2d8f..dc6666f 100755
> --- a/t/t9350-fast-export.sh
> +++ b/t/t9350-fast-export.sh
> @@ -504,4 +504,11 @@ test_expect_success 'refs are updated even if no commits need to be exported' '
> test_cmp expected actual
> '
>
> +test_expect_success 'use refspec' '
> + git fast-export --refspec refs/heads/master:refs/heads/foobar master | \
> + grep "^commit " | sort | uniq > actual &&
> + echo "commit refs/heads/foobar" > expected &&
> + test_cmp expected actual
> +'
> +
> test_done
>
I think it'd be good to add a test for multiple refspecs.
-Richard
next prev parent reply other threads:[~2013-09-23 1:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-29 15:23 [PATCH 0/9] transport-helper: updates Felipe Contreras
2013-08-29 15:23 ` [PATCH 1/9] transport-helper: add 'force' to 'export' helpers Felipe Contreras
2013-09-23 2:41 ` Richard Hansen
2013-09-23 2:39 ` Felipe Contreras
2013-08-29 15:23 ` [PATCH 2/9] transport-helper: check for 'forced update' message Felipe Contreras
2013-08-29 15:23 ` [PATCH 3/9] fast-export: improve argument parsing Felipe Contreras
2013-08-29 15:23 ` [PATCH 4/9] fast-export: add new --refspec option Felipe Contreras
2013-09-23 1:59 ` Richard Hansen [this message]
2013-09-23 2:35 ` Felipe Contreras
2013-08-29 15:23 ` [PATCH 5/9] transport-helper: add support for old:new refspec Felipe Contreras
2013-08-29 15:23 ` [PATCH 6/9] fast-import: add support to delete refs Felipe Contreras
2013-08-29 15:23 ` [PATCH 7/9] fast-export: " Felipe Contreras
2013-08-29 15:23 ` [PATCH 8/9] transport-helper: add support to delete branches Felipe Contreras
2013-09-23 1:50 ` Richard Hansen
2013-09-23 2:34 ` Felipe Contreras
2013-08-29 15:23 ` [PATCH 9/9] transport-helper: don't update refs in dry-run Felipe Contreras
2013-08-29 19:22 ` [PATCH 0/9] transport-helper: updates Junio C Hamano
2013-08-29 19:26 ` Felipe Contreras
2013-09-23 1:49 ` Richard Hansen
2013-09-23 2:32 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523FA07C.9040909@bbn.com \
--to=rhansen@bbn.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).