From: Richard Hansen <rhansen@bbn.com>
To: Felipe Contreras <felipe.contreras@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 1/9] transport-helper: add 'force' to 'export' helpers
Date: Sun, 22 Sep 2013 22:41:29 -0400 [thread overview]
Message-ID: <523FAA59.6040200@bbn.com> (raw)
In-Reply-To: <1377789808-2213-2-git-send-email-felipe.contreras@gmail.com>
On 2013-08-29 11:23, Felipe Contreras wrote:
> Otherwise they cannot know when to force the push or not (other than
> hacks).
>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
> transport-helper.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/transport-helper.c b/transport-helper.c
> index 63cabc3..62051a6 100644
> --- a/transport-helper.c
> +++ b/transport-helper.c
> @@ -814,6 +814,9 @@ static int push_refs_with_export(struct transport *transport,
> die("helper %s does not support dry-run", data->name);
> }
>
> + if (flags & TRANSPORT_PUSH_FORCE)
> + set_helper_option(transport, "force", "true");
Should the return value of set_helper_option() be checked?
Also, should there be a #define TRANS_OPT_FORCE "force" with
TRANS_OPT_FORCE added to boolean_options[]?
Thanks,
Richard
next prev parent reply other threads:[~2013-09-23 2:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-29 15:23 [PATCH 0/9] transport-helper: updates Felipe Contreras
2013-08-29 15:23 ` [PATCH 1/9] transport-helper: add 'force' to 'export' helpers Felipe Contreras
2013-09-23 2:41 ` Richard Hansen [this message]
2013-09-23 2:39 ` Felipe Contreras
2013-08-29 15:23 ` [PATCH 2/9] transport-helper: check for 'forced update' message Felipe Contreras
2013-08-29 15:23 ` [PATCH 3/9] fast-export: improve argument parsing Felipe Contreras
2013-08-29 15:23 ` [PATCH 4/9] fast-export: add new --refspec option Felipe Contreras
2013-09-23 1:59 ` Richard Hansen
2013-09-23 2:35 ` Felipe Contreras
2013-08-29 15:23 ` [PATCH 5/9] transport-helper: add support for old:new refspec Felipe Contreras
2013-08-29 15:23 ` [PATCH 6/9] fast-import: add support to delete refs Felipe Contreras
2013-08-29 15:23 ` [PATCH 7/9] fast-export: " Felipe Contreras
2013-08-29 15:23 ` [PATCH 8/9] transport-helper: add support to delete branches Felipe Contreras
2013-09-23 1:50 ` Richard Hansen
2013-09-23 2:34 ` Felipe Contreras
2013-08-29 15:23 ` [PATCH 9/9] transport-helper: don't update refs in dry-run Felipe Contreras
2013-08-29 19:22 ` [PATCH 0/9] transport-helper: updates Junio C Hamano
2013-08-29 19:26 ` Felipe Contreras
2013-09-23 1:49 ` Richard Hansen
2013-09-23 2:32 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523FAA59.6040200@bbn.com \
--to=rhansen@bbn.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).