From: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, jltobler@gmail.com, ps@pks.im
Subject: Re: [PATCH v2 3/3] repo: add -z as an alias for --format=nul to git-repo-structure
Date: Thu, 18 Dec 2025 20:02:41 -0300 [thread overview]
Message-ID: <5240C85D-7587-4042-AA75-58356BCFF351@gmail.com> (raw)
In-Reply-To: <xmqqh5txfv7b.fsf@gitster.g>
Hi, Junio!
> * Instead of munging the expected file so that it contains a NUL,
> and compare the actual output with it, munge the NUL terminated
> outout to make it text and compare with the expected file in text
> format.
Ok! I'll do that in the next version.
> * I see your -z output is "<key> LF <value> NUL", but was there a
> particular reason why "<key> NUL <value> NUL" was not chosen?
This was a suggestions by Phillip Wood [1]. We've chosen this format
following the format of git-config.
[1] https://lore.kernel.org/git/223c7cbd-610e-49e2-90e2-5914cbc0f1d7@gmail.com/
next prev parent reply other threads:[~2025-12-18 23:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-30 19:59 [PATCH] repo: add -z as an alias for --format=nul to git-repo-structure Lucas Seiki Oshiro
2025-12-01 2:21 ` Junio C Hamano
2025-12-01 8:28 ` Patrick Steinhardt
2025-12-01 14:34 ` Lucas Seiki Oshiro
2025-12-02 3:45 ` Junio C Hamano
2025-12-02 22:05 ` Lucas Seiki Oshiro
2025-12-01 15:11 ` Justin Tobler
2025-12-02 0:29 ` Lucas Seiki Oshiro
2025-12-04 20:10 ` [PATCH v2 0/3] " Lucas Seiki Oshiro
2025-12-04 20:10 ` [PATCH v2 1/3] repo: remove blank line from Documentation/git-repo.adoc Lucas Seiki Oshiro
2025-12-04 20:10 ` [PATCH v2 2/3] repo: use [--format=... | -z] instead of [-z] in git-repo-info synopsis Lucas Seiki Oshiro
2025-12-04 20:10 ` [PATCH v2 3/3] repo: add -z as an alias for --format=nul to git-repo-structure Lucas Seiki Oshiro
2025-12-11 5:23 ` Junio C Hamano
2025-12-18 23:02 ` Lucas Seiki Oshiro [this message]
2025-12-05 11:09 ` [PATCH v2 0/3] " Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5240C85D-7587-4042-AA75-58356BCFF351@gmail.com \
--to=lucasseikioshiro@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jltobler@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).