git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Stefan Näwe" <stefan.naewe@atlas-elektronik.com>
To: Git List <git@vger.kernel.org>
Cc: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Subject: Re: [Bug] git show crashes with deepened shallow clone
Date: Wed, 25 Sep 2013 17:27:59 +0200	[thread overview]
Message-ID: <524300FF.5000801@atlas-elektronik.com> (raw)
In-Reply-To: <5242F78C.5060607@atlas-elektronik.com>

Am 25.09.2013 16:47, schrieb Stefan Näwe:
> Just a quick report since I don't have time to bisect now (will do later
> if no other gitster is faster...)

I'd marry 'git bisect' if I wasn't already... ;-)

This is what it gives me if I use my script (slightly modified to also run make)
with 'git bisect run':

6035d6aad8ca11954c0d7821f6f3e7c047039c8f is the first bad commit
commit 6035d6aad8ca11954c0d7821f6f3e7c047039c8f
Author: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Date:   Sun May 26 08:16:15 2013 +0700

    fetch-pack: prepare updated shallow file before fetching the pack

    index-pack --strict looks up and follows parent commits. If shallow
    information is not ready by the time index-pack is run, index-pack may
    be led to non-existent objects. Make fetch-pack save shallow file to
    disk before invoking index-pack.

    git learns new global option --shallow-file to pass on the alternate
    shallow file path. Undocumented (and not even support --shallow-file=
    syntax) because it's unlikely to be used again elsewhere.

    Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>

:100644 100644 67bd5091be0b34bfea075cd60281d22cf5b34768 6e9c7cd9d5da7d24d4810b36039681f184325932 M      commit.h
:100644 100644 f156dd4fac30cda4e09c508b7091cdb8d96917e2 6b5467c6dec9645f53d83cdad2467a158db622c0 M      fetch-pack.c
:100644 100644 1ada169d5cff3051effee33c6f9ba5b9be15b2e6 88eef5a7cc6d36f6e17f4855945116dd6f1b0681 M      git.c
:100644 100644 6be915f38f1fe8dbe0a22c4cd8ae2569331f483f cbe2526d8c2b2643957eea2729a16269a7a74fab M      shallow.c
:040000 040000 5333beeb4db3fc37c37e5a4d03816c4750ce6b28 3b0fb999b8655155cba24e2d09ebff29058d29d7 M      t
bisect run success


Stefan
-- 
----------------------------------------------------------------
/dev/random says: Answers: $1 * Correct answers: $5 * Dumb looks: Free! *
python -c "print '73746566616e2e6e616577654061746c61732d656c656b74726f6e696b2e636f6d'.decode('hex')"

  parent reply	other threads:[~2013-09-25 15:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-25 14:47 [Bug] git show crashes with deepened shallow clone Stefan Näwe
2013-09-25 15:10 ` Stefan Näwe
2013-09-25 15:27 ` Stefan Näwe [this message]
2013-09-25 18:08   ` Stefan Näwe
2013-09-25 18:48     ` Jonathan Nieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=524300FF.5000801@atlas-elektronik.com \
    --to=stefan.naewe@atlas-elektronik.com \
    --cc=git@vger.kernel.org \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).