git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc Branchaud <marcnarc@xiplink.com>
To: "Lucas Sandery [three am design]" <lucas@threeamdesign.com.au>,
	git@vger.kernel.org
Subject: Re: gitk next/prev buttons
Date: Tue, 08 Oct 2013 13:50:51 -0400	[thread overview]
Message-ID: <525445FB.6000806@xiplink.com> (raw)
In-Reply-To: <524A33E5.7090001@threeamdesign.com.au>

On 13-09-30 10:31 PM, Lucas Sandery [three am design] wrote:
> The "next" and "prev" buttons are lacking consistency and logic. For RTL
> languages previous is almost always on the left, and next on the right. The
> words are contradictory, "next" actually goes to backwards chronologically,
> and "prev" goes forward. Could the positions of the buttons be switched and
> the text be replaced with "earlier" and "later"? This would make the
> reference time not just order, and would mean the updated UI would not be
> confused with the previous one.

I agree with you here (I like "older" and "newer" myself).

In theory gitk accepts the same arguments as "git rev-list", and in theory
you should be able to use things like --reverse to get the commits in a
different order.

However, in practice I don't think anyone futzes with the ordering much with
gitk.  gitk even ignores the --reverse and --timestamp options, and I've had
a hard time getting gitk to display commits in an order where "older" and
"newer" would not make sense.

> Also, the arrow-only next/previous buttons (beside the commit ID) should
> really point up and down. Horizontal directions are ambiguous for navigation
> of a vertical list.

Here I don't agree.  These arrows are purely about history navigation.  They
don't have anything to do with "up" or "down" in the list.  In that sense
they're more like the arrows in your web browser.

		M.

  parent reply	other threads:[~2013-10-08 17:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-01  2:31 gitk next/prev buttons Lucas Sandery [three am design]
2013-10-02  1:08 ` Lucas Sandery
2013-10-08 17:50 ` Marc Branchaud [this message]
2013-10-08 19:36   ` Jonathan Nieder
2013-10-08 20:45     ` Marc Branchaud
2013-12-18 16:04     ` [PATCHv2] gitk: Replace "next" and "prev" buttons with down and up arrows Marc Branchaud
2014-01-21 15:33       ` Marc Branchaud
2014-01-22 11:04         ` Paul Mackerras
2014-01-22 20:18           ` Junio C Hamano
2014-01-23 11:08             ` Paul Mackerras
2014-01-23 16:51               ` Junio C Hamano
2013-10-08 20:49   ` [PATCH] gitk: Rename "next" and "prev" buttons to "older" and "newer" Marc Branchaud

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=525445FB.6000806@xiplink.com \
    --to=marcnarc@xiplink.com \
    --cc=git@vger.kernel.org \
    --cc=lucas@threeamdesign.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).