From: Julien Carsique <julien.carsique@gmail.com>
To: "SZEDER Gábor" <szeder@ira.uka.de>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Ramkumar Ramachandra <artagnon@gmail.com>,
Simon Oosthoek <s.oosthoek@xs4all.nl>,
"Eduardo R . D'Avila" <erdavila@gmail.com>,
Felipe Contreras <felipe.contreras@gmail.com>
Subject: Re: [PATCH] git-prompt.sh: show the upstream abbrev name
Date: Thu, 10 Oct 2013 16:43:22 +0200 [thread overview]
Message-ID: <5256BD0A.30706@gmail.com> (raw)
In-Reply-To: <20131010135813.GF19704@goldbirke>
On 10/10/2013 15:58, SZEDER Gábor wrote:
> Hi,
>
> On Thu, Oct 10, 2013 at 03:32:13PM +0200, Julien Carsique wrote:
>> @@ -204,6 +206,9 @@ __git_ps1_show_upstream ()
>> *) # diverged from upstream
>> p=" u+${count#* }-${count% *}" ;;
>> esac
>> + if [[ -n "$count" && -n "$name" ]]; then
>> + p+=" $(git rev-parse --abbrev-ref "$upstream" 2>/dev/null)"
> The '+=' operator is not supported in all Bash versions we care about.
> Please write this as p="$p $(...)".
>
> Thanks,
> Gábor
>
Hi,
It's fixed.
Note '+=' was already used line 114:
svn_url_pattern+="\\|$value"
Thank you for the review,
next prev parent reply other threads:[~2013-10-10 14:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-10 13:32 [PATCH] git-prompt.sh: show the upstream abbrev name Julien Carsique
2013-10-10 13:58 ` SZEDER Gábor
2013-10-10 14:40 ` Julien Carsique
2013-10-10 14:43 ` Julien Carsique [this message]
2013-10-15 12:21 ` SZEDER Gábor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5256BD0A.30706@gmail.com \
--to=julien.carsique@gmail.com \
--cc=artagnon@gmail.com \
--cc=erdavila@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=s.oosthoek@xs4all.nl \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).