From: Sebastian Schuberth <sschuberth@gmail.com>
To: Stefan Zager <szager@google.com>, git@vger.kernel.org
Cc: msysGit <msysgit@googlegroups.com>,
Karsten Blees <karsten.blees@gmail.com>
Subject: Re: Windows performance / threading file access
Date: Thu, 10 Oct 2013 22:19:13 +0200 [thread overview]
Message-ID: <52570BC1.2040208@gmail.com> (raw)
In-Reply-To: <CAHOQ7J_ZZ=7j-5ULd7Tdvbiqg4inhwi+fue_w6WAtNRkvZSwsg@mail.gmail.com>
Please keep in mind to CC the msysgit mailing list for Windows-specific
stuff. I'm also CC'ing Karsten who has worked on performance
improvements for Git for Windows in the past.
Thanks for bringing this up!
--
Sebastian Schuberth
> Hi folks,
>
> I don't follow the mailing list carefully, so forgive me if this has
> been discussed before, but:
>
> I've noticed that when working with a very large repository using msys
> git, the initial checkout of a cloned repository is excruciatingly
> slow (80%+ of total clone time). The root cause, I think, is that git
> does all the file access serially, and that's really slow on Windows.
>
> Has anyone considered threading file access to speed this up? In
> particular, I've got my eye on this loop in unpack-trees.c:
>
> static struct checkout state;
> static int check_updates(struct unpack_trees_options *o)
> {
> unsigned cnt = 0, total = 0;
> struct progress *progress = NULL;
> struct index_state *index = &o->result;
> int i;
> int errs = 0;
>
> ...
>
> for (i = 0; i < index->cache_nr; i++) {
> struct cache_entry *ce = index->cache[i];
>
> if (ce->ce_flags & CE_UPDATE) {
> display_progress(progress, ++cnt);
> ce->ce_flags &= ~CE_UPDATE;
> if (o->update && !o->dry_run) {
> errs |= checkout_entry(ce, &state, NULL);
> }
> }
> }
> stop_progress(&progress);
> if (o->update)
> git_attr_set_direction(GIT_ATTR_CHECKIN, NULL);
> return errs != 0;
> }
>
>
> Any thoughts on adding threading around the call to checkout_entry?
>
>
> Thanks in advance,
>
> Stefan
--
--
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.
You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en
---
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
next prev parent reply other threads:[~2013-10-10 20:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-10 18:18 Windows performance / threading file access Stefan Zager
2013-10-10 20:19 ` Sebastian Schuberth [this message]
2013-10-11 0:51 ` Karsten Blees
2013-10-11 5:28 ` Stefan Zager
2013-10-11 5:35 ` Stefan Zager
2013-10-11 5:48 ` Duy Nguyen
2013-10-15 22:22 ` pro-logic
2013-10-17 16:50 ` Karsten Blees
2013-10-21 22:58 ` pro-logic
2013-10-22 14:30 ` Karsten Blees
2013-10-22 14:49 ` Sebastian Schuberth
2013-10-22 15:40 ` Karsten Blees
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52570BC1.2040208@gmail.com \
--to=sschuberth@gmail.com \
--cc=git@vger.kernel.org \
--cc=karsten.blees@gmail.com \
--cc=msysgit@googlegroups.com \
--cc=szager@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).