git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Lehmann <Jens.Lehmann@web.de>
To: Jonathan Nieder <jrnieder@gmail.com>, Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Anders Kaseorg <andersk@MIT.EDU>
Subject: Re: What's cooking in git.git (Oct 2013, #02; Mon, 14)
Date: Tue, 15 Oct 2013 21:42:14 +0200	[thread overview]
Message-ID: <525D9A96.6050209@web.de> (raw)
In-Reply-To: <20131015191656.GD9464@google.com>

Am 15.10.2013 21:16, schrieb Jonathan Nieder:
> So I suspect this will fix more scripts than it breaks, though it may
> still break some. :/

Hmm, I'm really not sure if we should do this or not.

> It might make sense to warn when passed multiple arguments and some
> include shell metacharacters, since that's probably rare, too, except
> it's punishing people who use multiple arguments as a way to avoid
> quoting issues.  Probably there's no replacement for just advertising
> the change loudly and seeking out scripts it could break.

And maybe only change that on a major version bump where people should
not be terribly surprised about such a change in behavior and are more
likely to read release notes?

I've thought about issuing a warning on certain quoting patterns too,
but dismissed that for not helping much in the scripting case. E.g. at
$dayjob we have foreach commands running in the shell execution for
quite some jobs on our Jenkins server; nobody would see any warnings
there until we'd have the reason to dig deeper int the logs because
something breaks.

  reply	other threads:[~2013-10-15 19:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-14 18:45 What's cooking in git.git (Oct 2013, #01; Mon, 14) Jonathan Nieder
2013-10-15  0:12 ` What's cooking in git.git (Oct 2013, #02; " Jonathan Nieder
2013-10-15  5:05   ` Ramkumar Ramachandra
2013-10-15 18:32   ` Junio C Hamano
2013-10-15 19:16     ` Jonathan Nieder
2013-10-15 19:42       ` Jens Lehmann [this message]
2013-10-15 20:05         ` Jonathan Nieder
2013-10-16 17:53           ` Jens Lehmann
2013-10-15 19:45   ` Jens Lehmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=525D9A96.6050209@web.de \
    --to=jens.lehmann@web.de \
    --cc=andersk@MIT.EDU \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).