From: Felipe Contreras <felipe.contreras@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>,
Stefan Beller <stefanbeller@googlemail.com>
Cc: Felipe Contreras <felipe.contreras@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 12/20] alias: trivial style fix
Date: Mon, 14 Oct 2013 16:21:43 -0500 [thread overview]
Message-ID: <525c6067716ea_197a905e84a2@nysa.notmuch> (raw)
In-Reply-To: <20131014141806.GB21200@google.com>
Jonathan Nieder wrote:
> Stefan Beller wrote:
> > On 10/12/2013 09:07 AM, Felipe Contreras wrote:
>
> >> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> >
> > Not sure if it's worth by a newcomer. ;)
>
> A second set of eyes is always welcome.
>
> My thoughts: I have to admit I don't see much value in mechanical
> replacements like this one when done piecemeal and without other more
> significant changes on top.
A code-style fix is a code-style fix. If you don't send and apply code-style
fixes, your code would remain forever inconsistent, and not following the
style.
It's interesting how the most successfull project in history has a different
take on this:
http://article.gmane.org/gmane.linux.acpi.devel/42407
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=915ea7e41439efa7793814cdf4338cb6b003538a
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=21fcb34e28e99291e91d83422f2824f11b3c9ce9
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=28ee793e7ad4a00e41c6267075501694c94451fb
> >> --- a/alias.c
> >> +++ b/alias.c
> >> @@ -5,7 +5,7 @@ static char *alias_val;
> >>
> >> static int alias_lookup_cb(const char *k, const char *v, void *cb)
> >> {
> >> - if (!prefixcmp(k, "alias.") && !strcmp(k+6, alias_key)) {
> >> + if (!prefixcmp(k, "alias.") && !strcmp(k + 6, alias_key)) {
>
> does not look worth the churn and mailing list noise to me.
>
> A patch that globally took care of these var+constant constructs
> without surrounding space and did nothing else, once and for all to
> avoid later noise, may or may not be useful. I suspect even that
> wouldn't be worth it, since "k+6" already seems perfectly readable.
This comes from the Linux kernel code-style:
----
Use one space around (on each side of) most binary and ternary operators,
such as any of these:
= + - < > * / % | & ^ <= >= == != ? :
----
So no, to me and a huge lot of developers it's not "perfectly readable".
--
Felipe Contreras
next prev parent reply other threads:[~2013-10-14 21:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-12 7:06 [PATCH 10/20] doc: git-foo was obsoleted several years ago Felipe Contreras
2013-10-12 7:06 ` [PATCH 00/20] Trivial paches Felipe Contreras
2013-10-12 7:06 ` [PATCH 03/20] pull: cleanup documentation Felipe Contreras
2013-10-12 7:06 ` [PATCH 20/20] add: avoid yoda conditions Felipe Contreras
2013-10-12 7:07 ` [PATCH 08/20] branch: trivial style fix Felipe Contreras
2013-10-12 7:07 ` [PATCH 15/20] pretty: " Felipe Contreras
2013-10-12 7:07 ` [PATCH 19/20] setup: trivial style fixes Felipe Contreras
2013-10-12 7:07 ` [PATCH 13/20] transport-helper: trivial style fix Felipe Contreras
2013-10-12 7:07 ` [PATCH 01/20] merge: simplify ff-only option Felipe Contreras
2013-10-12 7:07 ` [PATCH 16/20] revision: trivial style fixes Felipe Contreras
2013-10-12 9:08 ` Stefan Beller
2013-10-12 11:18 ` Felipe Contreras
2013-10-12 7:07 ` [PATCH 17/20] diff: trivial style fix Felipe Contreras
2013-10-12 7:07 ` [PATCH 05/20] remote: fix trivial memory leak Felipe Contreras
2013-10-12 7:07 ` [PATCH 07/20] shortlog: add missing declaration Felipe Contreras
2013-10-12 7:07 ` [PATCH 11/20] symbolic-ref: trivial style fix Felipe Contreras
2013-10-12 7:07 ` [PATCH 06/20] revision: add missing include Felipe Contreras
2013-10-12 7:07 ` [PATCH 18/20] run-command: trivial style fixes Felipe Contreras
2013-10-12 7:07 ` [PATCH 02/20] t: replace pulls with merges Felipe Contreras
2013-10-12 7:07 ` [PATCH 12/20] alias: trivial style fix Felipe Contreras
2013-10-12 8:55 ` Stefan Beller
2013-10-14 14:18 ` Jonathan Nieder
2013-10-14 21:21 ` Felipe Contreras [this message]
2013-10-12 7:07 ` [PATCH 04/20] fetch: add missing documentation Felipe Contreras
2013-10-12 7:07 ` [PATCH 09/20] sha1-name: trivial style cleanup Felipe Contreras
2013-10-12 7:07 ` [PATCH 14/20] describe: trivial style fixes Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525c6067716ea_197a905e84a2@nysa.notmuch \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=stefanbeller@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).