From: Michael Haggerty <mhagger@alum.mit.edu>
To: Stefan Beller <stefanbeller@googlemail.com>,
git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 1/2] refs: remove unused function invalidate_ref_cache
Date: Sun, 27 Oct 2013 05:26:57 +0100 [thread overview]
Message-ID: <526C9611.6090200@alum.mit.edu> (raw)
In-Reply-To: <1382806982-20634-1-git-send-email-stefanbeller@googlemail.com>
On 10/26/2013 07:03 PM, Stefan Beller wrote:
> The function 'invalidate_ref_cache' was introduced in 79c7ca5 (2011-10-17,
> invalidate_ref_cache(): rename function from invalidate_cached_refs())
> by a rename and elevated to be publicly usable in 8be8bde (2011-10-17,
> invalidate_ref_cache(): expose this function in the refs API)
>
> However it is not used anymore, as 8bf90dc (2011-10-17, write_ref_sha1():
> only invalidate the loose ref cache) and (much) later 506a760 (2013-04-22,
> refs: change how packed refs are deleted) removed any calls to this
> function. So it seems as if we don't need that function any more,
> good bye!
Looks good. Stefan, thanks for cleaning up after me!
Michael
--
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/
prev parent reply other threads:[~2013-10-27 4:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-26 17:03 [PATCH 1/2] refs: remove unused function invalidate_ref_cache Stefan Beller
2013-10-26 17:03 ` [PATCH 2/2] cache: remove unused function 'have_git_dir' Stefan Beller
2013-10-27 4:26 ` Michael Haggerty [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=526C9611.6090200@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=stefanbeller@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).