From: Sebastian Schuberth <sschuberth@gmail.com>
To: Johannes Sixt <j6t@kdbg.org>, git@vger.kernel.org
Cc: msysgit@googlegroups.com
Subject: Re: [PATCH 2/3] Windows: a test_cmp that is agnostic to random LF <> CRLF conversions
Date: Sat, 02 Nov 2013 21:33:28 +0100 [thread overview]
Message-ID: <52756198.2070900@gmail.com> (raw)
In-Reply-To: <e64878fec3f026802e8d3958a1e6213428cab778.1382814437.git.j6t@kdbg.org>
On 26.10.2013 21:17, Johannes Sixt wrote:
> In a number of tests, output that was produced by a shell script is
> compared to expected output using test_cmp. Unfortunately, the MSYS bash--
> when invoked via git, such as in hooks--converts LF to CRLF on output
> (as produced by echo and printf), which leads to many false positives.
As you correctly point out the LF vs. CRLF issues are caused by MSYS
bash. Then why are the functions called mingw_* instead of msys_*? I'd
prefer to make very clear that not MinGW but MSYS is the culprit
concerning the LF vs. CRLF issues (and also the path mangling issues).
--
Sebastian Schuberth
--
--
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.
You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en
---
You received this message because you are subscribed to the Google Groups "msysGit" group.
To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
next prev parent reply other threads:[~2013-11-02 20:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-26 19:17 [PATCH 0/3] Fix tests on Windows caused by random CRLF output Johannes Sixt
2013-10-26 19:17 ` [PATCH 1/3] t5300-pack-object: do not compare binary data using test_cmp Johannes Sixt
2013-10-26 19:17 ` [PATCH 2/3] Windows: a test_cmp that is agnostic to random LF <> CRLF conversions Johannes Sixt
2013-11-02 20:33 ` Sebastian Schuberth [this message]
2013-11-02 20:40 ` Johannes Sixt
2013-11-02 20:47 ` Sebastian Schuberth
2013-11-03 8:32 ` Johannes Sixt
2013-10-26 19:17 ` [PATCH 3/3] tests: undo special treatment of CRLF for Windows Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52756198.2070900@gmail.com \
--to=sschuberth@gmail.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=msysgit@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).