From: "Torsten Bögershausen" <tboegi@web.de>
To: "Jeff King" <peff@peff.net>, "Torsten Bögershausen" <tboegi@web.de>
Cc: Ramsay Jones <ramsay@ramsay1.demon.co.uk>,
Vicent Marti <tanoku@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH 0/5] fix up 'jk/pack-bitmap' branch
Date: Sat, 09 Nov 2013 12:35:09 +0100 [thread overview]
Message-ID: <527E1DED.9030800@web.de> (raw)
In-Reply-To: <20131108222903.GB19912@sigill.intra.peff.net>
On 2013-11-08 23.29, Jeff King wrote:
> On Fri, Nov 08, 2013 at 06:10:30PM +0100, Torsten Bögershausen wrote:
>
>> Side question:
>> Do we have enough test coverage for htonll()/ntohll(),
>> or do we want do the "module test" which I send a couple of days before ?
>
> The series adds tests for building and using the ewah bitmaps, which in
> turn rely on the htonll code. So they are being tested in the existing
> series.
>
> -Peff
You are thinking about t5310-pack-bitmaps.sh ?
If I do like this in compat/bswap.h
# define ntohll(n) (n)
# define htonll(n) (n)
(on an Intel processor, little endian)
then t5310 passes, even if the uint64_t words are written
in little endian to disc instead of big endian.
What do I miss?
/torsten
next prev parent reply other threads:[~2013-11-09 11:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-07 21:58 [PATCH 0/5] fix up 'jk/pack-bitmap' branch Ramsay Jones
2013-11-07 22:19 ` Jeff King
2013-11-08 1:39 ` Vicent Martí
2013-11-08 17:10 ` Torsten Bögershausen
2013-11-08 18:23 ` Ramsay Jones
2013-11-08 22:29 ` Jeff King
2013-11-09 11:35 ` Torsten Bögershausen [this message]
2013-11-09 17:25 ` Johannes Sixt
2013-11-09 21:03 ` Thomas Rast
2013-11-09 21:21 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527E1DED.9030800@web.de \
--to=tboegi@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=ramsay@ramsay1.demon.co.uk \
--cc=tanoku@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).