From: Jens Lehmann <Jens.Lehmann@web.de>
To: Thomas Rast <tr@thomasrast.ch>,
Dmitry Neverov <dmitry.neverov@jetbrains.com>
Cc: git@vger.kernel.org, "Daniel Graña" <dangra@gmail.com>
Subject: Re: submodule update and core.askpass
Date: Sat, 16 Nov 2013 23:39:41 +0100 [thread overview]
Message-ID: <5287F42D.5090900@web.de> (raw)
In-Reply-To: <87eh6gkoq9.fsf@linux-k42r.v.cablecom.net>
Am 16.11.2013 22:42, schrieb Thomas Rast:
> Dmitry Neverov <dmitry.neverov@jetbrains.com> writes:
>
>> git -c core.askpass=pass.sh clone main-repo
>> cd main-repo
>> git submodule init
>> git submodule sync
>> git -c core.askpass=pass.sh submodule update
>>
>> The last command asks for a password interactively.
>>
>> I've run bisect, it seems like it started failing from commit
>> be8779f7ac9a3be9aa783df008d59082f4054f67. I've checked: submodule update
>> works fine in 1.8.5.rc2 with removed call to clear_local_git_env.
>
> Aside from GIT_CONFIG_PARAMETERS, which this needs ...
Yes, if I understand GIT_CONFIG_PARAMETERS correctly we should not
clean it as the user explicitly asked us to use that setting.
> ..., I wonder if we
> should also let other variables pass through. For example, if the user
> went out of their way to set GIT_ALTERNATE_OBJECT_DIRECTORIES, shouldn't
> we also respect that?
Hmm, I'm not so sure. Does the user really want the setting of
GIT_ALTERNATE_OBJECT_DIRECTORIES to be honored inside the submodule
too or would he want a different setting (including none)? I suspect
different users would give different answers. And wouldn't a working
GIT_CONFIG_PARAMETERS (or configuring the submodule after the initial
clone) be the solution for that?
> The list of variables that is unset by clear_local_git_env is $(git
> rev-parse --local-env-vars), currently
>
> GIT_ALTERNATE_OBJECT_DIRECTORIES
> GIT_CONFIG
> GIT_CONFIG_PARAMETERS
> GIT_OBJECT_DIRECTORY
> GIT_DIR
> GIT_WORK_TREE
> GIT_IMPLICIT_WORK_TREE
> GIT_GRAFT_FILE
> GIT_INDEX_FILE
> GIT_NO_REPLACE_OBJECTS
> GIT_PREFIX
next prev parent reply other threads:[~2013-11-16 22:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-16 21:24 submodule update and core.askpass Dmitry Neverov
2013-11-16 21:42 ` Thomas Rast
2013-11-16 22:39 ` Jens Lehmann [this message]
2013-11-22 12:33 ` Dmitry Neverov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5287F42D.5090900@web.de \
--to=jens.lehmann@web.de \
--cc=dangra@gmail.com \
--cc=dmitry.neverov@jetbrains.com \
--cc=git@vger.kernel.org \
--cc=tr@thomasrast.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).