From: "\"Andrés G. Aragoneses\"" <knocte@gmail.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCHv3] transport: Catch non positive --depth option value
Date: Tue, 26 Nov 2013 00:34:43 +0100 [thread overview]
Message-ID: <5293DE93.3020008@gmail.com> (raw)
In-Reply-To: <CACsJy8B0qBmBkx0n2B=ivUqZTgVz-ZLhTQ_nVJ4AV0njnZksfw@mail.gmail.com>
On 22/11/13 02:18, Duy Nguyen wrote:
> On Fri, Nov 22, 2013 at 3:18 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> Have you run the tests with this patch? It seems that it breaks
>> quite a lot of them, including t5500, t5503, t5510, among others.
>
> I guess it's caused by builtin/fetch.c:backfill_tags(). And the call
> could be replaced with
>
> transport_set_option(transport, TRANS_OPT_DEPTH, NULL);
>
Not sure what you mean,
https://github.com/git/git/blob/master/t/t5550-http-fetch.sh doesn't
call backfill_tags. What do you mean?
Thanks
next prev parent reply other threads:[~2013-11-25 23:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 16:06 [PATCH] transport: Catch non positive --depth option value "Andrés G. Aragoneses"
2013-11-16 2:58 ` Duy Nguyen
2013-11-18 16:51 ` Junio C Hamano
2013-11-18 22:45 ` [PATCHv2] " "Andrés G. Aragoneses"
2013-11-19 17:15 ` Junio C Hamano
2013-11-21 15:27 ` [PATCHv3] " "Andrés G. Aragoneses"
2013-11-21 17:34 ` Junio C Hamano
2013-11-21 20:18 ` Junio C Hamano
2013-11-22 1:18 ` Duy Nguyen
2013-11-25 23:34 ` "Andrés G. Aragoneses" [this message]
2013-11-26 3:06 ` Duy Nguyen
2013-11-26 10:43 ` "Andrés G. Aragoneses"
2013-11-26 11:09 ` Duy Nguyen
2013-11-26 11:41 ` [PATCHv4] " "Andrés G. Aragoneses"
2013-11-26 19:09 ` Jonathan Nieder
2013-11-26 22:19 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5293DE93.3020008@gmail.com \
--to=knocte@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).