From: Johannes Sixt <j.sixt@viscovery.net>
To: Thomas Rast <trast@inf.ethz.ch>
Cc: Paul Mackerras <paulus@samba.org>,
Git Mailing List <git@vger.kernel.org>
Subject: gitk's back button broken (Refactor per-line part of getblobdiffline and its support)
Date: Mon, 16 Dec 2013 14:56:24 +0100 [thread overview]
Message-ID: <52AF0688.3070104@viscovery.net> (raw)
To reproduce, start gitk in any repository, click a commit, then the
"back" button (left-pointing arrow button) or type Alt+Cursor-Left. The
error I get is this:
can't use non-numeric string as operand of "!"
can't use non-numeric string as operand of "!"
while executing
"if {!$ateof} {
set nlines [expr {[winfo height $ctext]
/ [font metrics textfont -linespace]}]
if {[$ctext compare "$target_scrollpos + $nlines ..."
(procedure "maybe_scroll_ctext" line 5)
invoked from within
"maybe_scroll_ctext ateof"
(procedure "blobdiffmaybeseehere" line 6)
invoked from within
"blobdiffmaybeseehere [eof $bdf]"
(procedure "getblobdiffline" line 15)
invoked from within
"getblobdiffline filef5ec60 5de460a2cfdd4acbadd41355a5b34dc69e93b89e"
("eval" body line 1)
invoked from within
"eval $script"
(procedure "dorunq" line 11)
invoked from within
"dorunq"
("after" script)
After dismissing the error, gitk is still responsive, but does not show
diffs anymore.
The error bisects to 5de460a2c (gitk: Refactor per-line part of
getblobdiffline and its support) which is already merged downstream into git.
Could you please have a look?
-- Hannes
next reply other threads:[~2013-12-16 13:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-16 13:56 Johannes Sixt [this message]
2013-12-19 7:14 ` [PATCH] gitk: Fix typo in proc blobdiffmaybeseehere Johannes Sixt
2013-12-19 23:16 ` Thomas Rast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AF0688.3070104@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=paulus@samba.org \
--cc=trast@inf.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).