From: Karsten Blees <karsten.blees@gmail.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Thomas Rast <tr@thomasrast.ch>,
Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org
Subject: Re: What's cooking in git.git (Dec 2013, #02; Fri, 6)
Date: Wed, 18 Dec 2013 15:05:04 +0100 [thread overview]
Message-ID: <52B1AB90.1080800@gmail.com> (raw)
In-Reply-To: <52B19EBC.50609@gmail.com>
Am 18.12.2013 14:10, schrieb Karsten Blees:
> + printf("sizeof(pointer+int) (%u) is not a "
> + "multiple of sizeof(pointer) (%u)!\n",
> + sizeof(struct pointer_int),
> + sizeof(void *));
Should be:
- sizeof(struct pointer_int),
- sizeof(void *));
+ (unsigned) sizeof(struct pointer_int),
+ (unsigned) sizeof(void *));
(sizeof() is 'unsigned int' on 32-bit and 'long unsigned int' on 64-bit; without the cast, "%u" produces warnings on 64-bit and "%lu" on 32-bit...)
next prev parent reply other threads:[~2013-12-18 14:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 23:52 What's cooking in git.git (Dec 2013, #02; Fri, 6) Junio C Hamano
2013-12-07 10:03 ` Felipe Contreras
2013-12-07 20:30 ` Felipe Contreras
2013-12-09 21:00 ` Junio C Hamano
2013-12-07 17:03 ` Thomas Rast
2013-12-09 22:33 ` Jeff King
2013-12-09 22:51 ` Junio C Hamano
2013-12-07 18:49 ` Matthieu Moy
2013-12-07 19:56 ` Karsten Blees
2013-12-07 22:23 ` Thomas Rast
2013-12-07 22:32 ` Karsten Blees
2013-12-08 10:20 ` Thomas Rast
2013-12-09 14:03 ` Karsten Blees
2013-12-09 20:08 ` Jonathan Nieder
2013-12-09 23:19 ` Karsten Blees
2013-12-09 23:45 ` Jonathan Nieder
2013-12-18 13:10 ` Karsten Blees
2013-12-18 14:05 ` Karsten Blees [this message]
2013-12-18 14:12 ` Karsten Blees
2013-12-09 17:43 ` Junio C Hamano
2013-12-09 17:48 ` Junio C Hamano
2013-12-18 13:41 ` [PATCH] hashmap.h: Use 'unsigned int' for hash-codes everywhere Karsten Blees
2013-12-18 17:46 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B1AB90.1080800@gmail.com \
--to=karsten.blees@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=tr@thomasrast.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).