From: Michael Haggerty <mhagger@alum.mit.edu>
To: Kirill Likhodedov <kirill.likhodedov@jetbrains.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: git log --no-walk --tags produces strange result for certain user
Date: Thu, 16 Jan 2014 11:31:20 +0100 [thread overview]
Message-ID: <52D7B4F8.1010209@alum.mit.edu> (raw)
In-Reply-To: <AEF2BC21-6EE1-479F-BC63-7A5B95406A7F@jetbrains.com>
On 12/16/2013 12:52 PM, Kirill Likhodedov wrote:
> I received one more complaint for this issue, and now it appears in a public repository https://github.com/spray/spray
>
> To reproduce:
>
> # git clone https://github.com/spray/spray
> # cd spray
> # git log --no-walk --tags --pretty="%H %d" --decorate=full | tail -3
> 3273edafcd9f9701d62e061c5257c0a09e2e1fb7 (tag: refs/tags/v0.8.0-RC1)
> ff3a2946bc54da76ddb47e82c81419cc7ae3db6b (tag: refs/tags/v0.7.0)
> 8b4043428b90b7f45b7241b3c2c032cf785479ce
>
> So here the last hash doesn't have a decoration.
The problem is that reference refs/tags/v0.5.0 points at a tag object
8f6ca98087 which itself points at another tag object 2eddbcbff4 which
finally points at commit 8b4043428b. Probably we should handle
recursive tag objects like this, but OTOH I can't think of a reason why
one would want to create them in the first place.
Michael
--
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/
next prev parent reply other threads:[~2014-01-16 10:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 10:08 git log --no-walk --tags produces strange result for certain user Kirill Likhodedov
2013-12-07 15:04 ` Kirill Likhodedov
[not found] ` <52AEB181.9020006@alum.mit.edu>
2013-12-16 11:52 ` Kirill Likhodedov
2013-12-17 0:40 ` brian m. carlson
2013-12-17 4:28 ` [PATCH] log: properly handle decorations with chained tags brian m. carlson
2013-12-18 0:36 ` Junio C Hamano
2013-12-19 3:18 ` brian m. carlson
2013-12-19 18:44 ` Junio C Hamano
2013-12-19 23:44 ` brian m. carlson
2014-01-16 10:31 ` Michael Haggerty [this message]
2014-01-17 8:28 ` git log --no-walk --tags produces strange result for certain user Michael Haggerty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D7B4F8.1010209@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=git@vger.kernel.org \
--cc=kirill.likhodedov@jetbrains.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).